DBFS with multiple connections between sub grids #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
between agents in DBFS algorithm when there are multiple connections between two adjacent GridAgents. Co-authored-by: sebastian-peter <sebastian.peter@tu-dortmund.de>
Codecov Report
@@ Coverage Diff @@
## dev #25 +/- ##
==========================================
+ Coverage 79.78% 79.84% +0.05%
==========================================
Files 159 159
Lines 5838 5869 +31
Branches 80 81 +1
==========================================
+ Hits 4658 4686 +28
- Misses 1180 1183 +3
Continue to review full report at Codecov.
|
sebastian-peter
previously requested changes
Dec 14, 2021
…nections # Conflicts: # CHANGELOG.md
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
to inferior GridAgents
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
and relevant places of usage
ckittl
force-pushed
the
ck/#22-dbfsMultipleConnections
branch
from
c650307
to
73dcc5a
Compare
|
I guess #131 should be merged before this PR. |
…nections # Conflicts: # CHANGELOG.md
5 tasks
# Conflicts: # CHANGELOG.md # src/main/scala/edu/ie3/simona/config/ConfigFailFast.scala # src/main/scala/edu/ie3/simona/config/RefSystemParser.scala # src/main/scala/edu/ie3/simona/config/SimonaConfig.scala # src/test/scala/edu/ie3/simona/config/ConfigFailFastSpec.scala # src/test/scala/edu/ie3/simona/config/RefSystemParserSpec.scala
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danielfeismann
requested changes
Jul 20, 2022
Co-authored-by: Daniel Feismann <98817556+danielfeismann@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Analysis Details1 Issue
Coverage and Duplications
Project ID: edu.ie3:simona |
# Conflicts: # CHANGELOG.md # src/main/scala/edu/ie3/simona/agent/grid/PowerFlowSupport.scala # src/test/scala/edu/ie3/simona/agent/grid/DBFSAlgorithmCenGridSpec.scala
sebastian-peter
changed the title
t-ober
requested changes
Aug 1, 2022
Comment on lines
295
to
308
|
|
||
| implicit class RichUnit[Q <: Quantity[Q]]( | ||
| private val unit: measure.Unit[Q] | ||
| ) extends AnyVal { | ||
|
|
||
| /** Transform some power unit to given unit with the same prefix | ||
| * @param targetUnit | ||
| * the target system unit | ||
| * @return | ||
| * this unit converted to given | ||
| */ | ||
| def toEquivalentIn(targetUnit: measure.Unit[Q]): measure.Unit[Q] = | ||
| targetUnit.transform(unit.getConverterTo(unit.getSystemUnit)) | ||
| } |
There was a problem hiding this comment.
I think it makes sense to transfer this class (as well as the RichQuantity) into the PowerSystemUtils as it might come in handy for other projects as well and we already have som Quantity related utils there.
There was a problem hiding this comment.
I'm fine with doing that at some point in time. I'd leave it in SIMONA until it's available in PSU.
There was a problem hiding this comment.
ie3-institute/PowerSystemUtils#289
If you want to make a quick review we can add it while were at it
There was a problem hiding this comment.
Ok, that was really quick. I removed RichUnit and RichQuantity here and replaced all calls with ones to the equivalents in PSU
t-ober
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22
Resolves #129
Edit (SP): Please review #266 first!
Edit (SP): Test grid for
DBFSAlgorithmCenGridSpecadapted to only have three inferior subgrids, one of which having two connections to the central subgrid