Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect for slack voltage angle in distributed power flow calculation #71

Merged
merged 11 commits into from
Jul 31, 2022
Merged

Respect for slack voltage angle in distributed power flow calculation #71

merged 11 commits into from
Jul 31, 2022

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Jan 11, 2022

Resolves #69

@ckittl ckittl added the bug Something isn't working label Jan 11, 2022
@ckittl ckittl self-assigned this Jan 11, 2022
@ckittl
Fix reactive power
1eba305 
in Evcs test
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #71 (31057ba) into dev (7b3fbd5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #71   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files         159      159           
  Lines        5839     5835    -4     
  Branches       81       81           
=======================================
- Hits         4645     4642    -3     
+ Misses       1194     1193    -1
Impacted Files Coverage Δ
...cala/edu/ie3/simona/agent/grid/DBFSAlgorithm.scala 82.84% <0.00%> (-0.90%) ⬇️
...a/edu/ie3/simona/agent/grid/PowerFlowSupport.scala 80.39% <0.00%> (+3.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3fbd5...31057ba. Read the comment docs.

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
1 similar comment
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
1 similar comment
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
sebastian-peter
sebastian-peter previously requested changes May 2, 2022
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff I noticed

src/main/scala/edu/ie3/simona/agent/grid/PowerFlowSupport.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/agent/grid/PowerFlowSupport.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/agent/grid/PowerFlowSupport.scala Outdated Show resolved Hide resolved
@sebastian-peter sebastian-peter self-assigned this May 3, 2022
@sebastian-peter sebastian-peter dismissed their stale review May 3, 2022 10:11

I'm taking over the branch

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
danielfeismann
danielfeismann previously approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thank you!

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
danielfeismann
danielfeismann previously approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

1 Issue

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell1 Code Smell

Coverage and Duplications

  • 90 percent coverage95.35% Coverage (81.90% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@sebastian-peter
Merge branch 'dev' into ck/#69-slackVoltageAngle
31057ba 
# Conflicts:
#	src/main/scala/edu/ie3/simona/agent/grid/PowerFlowSupport.scala
danielfeismann
danielfeismann approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for me. Thanks for take care of this one.

@danielfeismann danielfeismann merged commit a125830 into dev Jul 31, 2022
@danielfeismann danielfeismann deleted the ck/#69-slackVoltageAngle branch July 31, 2022 10:31
sebastian-peter added a commit that referenced this pull request Jul 31, 2022
@sebastian-peter
Applying test adaptations of #71 (slack voltage angle)
d99ce36
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

@sebastian-peter sebastian-peter sebastian-peter left review comments

@johanneshiry johanneshiry Awaiting requested review from johanneshiry

@t-ober t-ober Awaiting requested review from t-ober

Assignees

@sebastian-peter sebastian-peter

@ckittl ckittl

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Respect for voltage angle in distributed power flow
3 participants
@ckittl @sebastian-peter @danielfeismann