Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

no-unreachable should not be disabled #347

Open
benj-dobs opened this issue Apr 22, 2024 · 1 comment · May be fixed by #357
Open

no-unreachable should not be disabled #347

benj-dobs opened this issue Apr 22, 2024 · 1 comment · May be fixed by #357

Comments

@benj-dobs
Copy link

The TypeScript compiler only enforces this check if explicitly configured to do so: https://www.typescriptlang.org/tsconfig#allowUnreachableCode

(Default behaviour is just to surface an editor warning.)

no-unreachable is disabled here:

'no-unreachable': 'off',

I think it would be more in-keeping with the spirit of this config to leave it enabled, rather than requiring users to have allowUnreachableCode: false in their tsconfig file to achieve the same behaviour.

@benj-dobs
Copy link
Author

I've raised an issue for the ESLint docs too: eslint/eslint#18378

Kenneth-Sills added a commit to Kenneth-Sills/eslint-config-airbnb-typescript-original that referenced this issue Aug 5, 2024
Not marked as a breaking change since this was *intended* to be
enabled de-facto.

Closes iamturns#347.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant