Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-unreachable should not be disabled #4

Closed
Kenneth-Sills opened this issue Aug 25, 2024 · 1 comment · Fixed by #5
Closed

no-unreachable should not be disabled #4

Kenneth-Sills opened this issue Aug 25, 2024 · 1 comment · Fixed by #5
Assignees
@Kenneth-Sills
Labels
bug Something isn't working released

Comments

@Kenneth-Sills
Copy link
Owner

Migrated from upstream issue.

The TypeScript compiler only enforces this check if explicitly configured to do so: typescriptlang.org/tsconfig#allowUnreachableCode

(Default behaviour is just to surface an editor warning.)

no-unreachable is disabled here.

I think it would be more in-keeping with the spirit of this config to leave it enabled, rather than requiring users to have allowUnreachableCode: false in their tsconfig file to achieve the same behaviour.
@Kenneth-Sills Kenneth-Sills mentioned this issue Aug 25, 2024
Merged
@Kenneth-Sills Kenneth-Sills self-assigned this Aug 25, 2024
@Kenneth-Sills Kenneth-Sills added the bug Something isn't working label Aug 25, 2024
Kenneth-Sills added a commit that referenced this issue Aug 25, 2024
@Kenneth-Sills
fix: re-enable no-unreachable, since TS does NOT handle it by defau…
3b90506 
…lt (#5)

Not marked as a breaking change since this was *intended* and enabled de jure, just not de facto.

Closes #4
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kenneth-Sills Kenneth-Sills

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
1 participant
@Kenneth-Sills