Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds plugin for plural getters/setters #996

Merged
merged 3 commits into from
Aug 10, 2020
Merged

feat: adds plugin for plural getters/setters #996

merged 3 commits into from
Aug 10, 2020

Conversation

spence-s
Copy link
Contributor

@spence-s spence-s commented Aug 8, 2020

fixes #692

@codecov
Copy link

codecov bot commented Aug 8, 2020 •
edited
Loading

Codecov Report

Merging #996 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #996   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          170       171    +1     
  Lines         1484      1488    +4     
  Branches       314       314           
=========================================
+ Hits          1484      1488    +4
Impacted Files Coverage Δ
src/plugin/pluralGetSet/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747c0fb...f249660. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Aug 9, 2020 •
edited
Loading

Thanks. Please add the relevant type d.ts file. like https://github.com/iamkun/dayjs/blob/dev/types/plugin/isoWeek.d.ts

And maybe we use this syntax proto.map to reduce our main bundle size as well? #997

@iamkun iamkun merged commit f76e3ce into iamkun:dev Aug 10, 2020
iamkun pushed a commit that referenced this pull request Aug 10, 2020
@semantic-release-bot
chore(release): 1.8.33 [skip ci]
6e5ffce 
## [1.8.33](v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](#996)) ([f76e3ce](f76e3ce))
* Add typescript type defs in esm build ([#985](#985)) ([50e3b3c](50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](#993)) ([f2e5f32](f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](#994)) ([22f3d49](22f3d49)), closes [#992](#992) [#989](#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](#987)) ([b07182b](b07182b)), closes [#986](#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](#995)) ([747c0fb](747c0fb))
* Update pt-br locale weekStart 0 ([#984](#984)) ([0f881c1](0f881c1))
@iamkun
Copy link
Owner

iamkun commented Aug 10, 2020

🎉 This PR is included in version 1.8.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.33 [skip ci]
7fba66b 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([f76e3ce](iamkun/dayjs@f76e3ce))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([50e3b3c](iamkun/dayjs@50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([f2e5f32](iamkun/dayjs@f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([22f3d49](iamkun/dayjs@22f3d49)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([b07182b](iamkun/dayjs@b07182b)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([747c0fb](iamkun/dayjs@747c0fb))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([0f881c1](iamkun/dayjs@0f881c1))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.33 [skip ci]
217a297 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([f76e3ce](iamkun/dayjs@f76e3ce))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([50e3b3c](iamkun/dayjs@50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([f2e5f32](iamkun/dayjs@f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([22f3d49](iamkun/dayjs@22f3d49)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([b07182b](iamkun/dayjs@b07182b)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([747c0fb](iamkun/dayjs@747c0fb))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([0f881c1](iamkun/dayjs@0f881c1))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this pull request Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.8.33 [skip ci]
f41e393 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([d2c8a00](iamkun/dayjs@d2c8a00))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([212e799](iamkun/dayjs@212e799))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([0679b8f](iamkun/dayjs@0679b8f))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([69a9377](iamkun/dayjs@69a9377)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([bb49a77](iamkun/dayjs@bb49a77)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([1b34a7f](iamkun/dayjs@1b34a7f))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([e26af6b](iamkun/dayjs@e26af6b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getter/setter plural aliases missing (e.g. hour() works but hours() does not)
2 participants
@spence-s @iamkun