Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong time zone offset in 'Asia/Tokyo' when using 'timezone' plugin #986

Closed
makitow opened this issue Aug 6, 2020 · 2 comments · Fixed by #987
Closed

Wrong time zone offset in 'Asia/Tokyo' when using 'timezone' plugin #986

makitow opened this issue Aug 6, 2020 · 2 comments · Fixed by #987
Labels
☢️Bug Something isn't working released

Comments

@makitow
Copy link

makitow commented Aug 6, 2020

Describe the bug
Wrong time zone offset in 'Asia/Tokyo' when using 'timezone' plugin

Expected behavior

dayjs.extend(utc);
dayjs.extend(timezone);

console.log(dayjs().tz('Asia/Tokyo').format('Z'));
// => +08:59.995649999999955

Information

  • Day.js Version 1.8.32
  • OS: mac
  • Browser Google Chrome 84
  • Time zone: GMT+09:00 JST
@iamkun iamkun added the ☢️Bug Something isn't working label Aug 6, 2020
@iamkun
Copy link
Owner

iamkun commented Aug 6, 2020

Thanks, will fix it in the next release.

iamkun added a commit that referenced this issue Aug 6, 2020
@iamkun
fix: fix Timezone plugin UTCOffset rounding bug
6a83469 
fix #986
@iamkun iamkun mentioned this issue Aug 6, 2020
Merged
iamkun added a commit that referenced this issue Aug 6, 2020
@iamkun
fix: Fix Timezone plugin UTCOffset rounding bug (#987)
b07182b 
fix #986
iamkun pushed a commit that referenced this issue Aug 10, 2020
@semantic-release-bot
chore(release): 1.8.33 [skip ci]
6e5ffce 
## [1.8.33](v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](#996)) ([f76e3ce](f76e3ce))
* Add typescript type defs in esm build ([#985](#985)) ([50e3b3c](50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](#993)) ([f2e5f32](f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](#994)) ([22f3d49](22f3d49)), closes [#992](#992) [#989](#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](#987)) ([b07182b](b07182b)), closes [#986](#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](#995)) ([747c0fb](747c0fb))
* Update pt-br locale weekStart 0 ([#984](#984)) ([0f881c1](0f881c1))
@iamkun
Copy link
Owner

iamkun commented Aug 10, 2020

🎉 This issue has been resolved in version 1.8.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.33 [skip ci]
7fba66b 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([f76e3ce](iamkun/dayjs@f76e3ce))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([50e3b3c](iamkun/dayjs@50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([f2e5f32](iamkun/dayjs@f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([22f3d49](iamkun/dayjs@22f3d49)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([b07182b](iamkun/dayjs@b07182b)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([747c0fb](iamkun/dayjs@747c0fb))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([0f881c1](iamkun/dayjs@0f881c1))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.33 [skip ci]
217a297 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([f76e3ce](iamkun/dayjs@f76e3ce))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([50e3b3c](iamkun/dayjs@50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([f2e5f32](iamkun/dayjs@f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([22f3d49](iamkun/dayjs@22f3d49)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([b07182b](iamkun/dayjs@b07182b)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([747c0fb](iamkun/dayjs@747c0fb))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([0f881c1](iamkun/dayjs@0f881c1))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this issue Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.8.33 [skip ci]
f41e393 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([d2c8a00](iamkun/dayjs@d2c8a00))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([212e799](iamkun/dayjs@212e799))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([0679b8f](iamkun/dayjs@0679b8f))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([69a9377](iamkun/dayjs@69a9377)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([bb49a77](iamkun/dayjs@bb49a77)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([1b34a7f](iamkun/dayjs@1b34a7f))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([e26af6b](iamkun/dayjs@e26af6b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️Bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix Timezone plugin UTCOffset rounding bug iamkun/dayjs
2 participants
@iamkun @makitow