fix: Add function handling for relativeTime.future and relativeTime.past #1197

drgx · 2020-11-09T13:55:41Z

codecov · 2020-11-09T13:57:28Z

Codecov Report

Merging #1197 (a06c6f4) into dev (b56936a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #1197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          174       174           
  Lines         1654      1657    +3     
  Branches       376       377    +1     
=========================================
+ Hits          1654      1657    +3

Impacted Files	Coverage Δ
src/plugin/relativeTime/index.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56936a...a06c6f4. Read the comment docs.

drgx · 2020-11-09T19:24:44Z

Will fix the test

iamkun · 2020-11-10T03:11:13Z

Thanks, please add the relevant unit test to make the CI pass.

drgx · 2020-11-11T05:22:07Z

Updated please kindly help to review 🙇

iamkun · 2020-11-11T05:33:06Z

src/locale/lv.js

@@ -17,6 +17,21 @@ const locale = {
    LL: 'YYYY. [gada] D. MMMM',
    LLL: 'YYYY. [gada] D. MMMM, HH:mm',
    LLLL: 'YYYY. [gada] D. MMMM, dddd, HH:mm'
+  },
+  relativeTime: {


is this a merge error?

oops my bad.. fixed..

…nction

iamkun · 2020-11-12T19:18:40Z

LGTM

skywritergr · 2020-11-17T11:39:25Z

I actually had the same issue. Is there a plan to release this in the near future? Thanks for all the hard work.

iamkun · 2020-11-19T02:28:19Z

@skywritergr will do it in the next week I hope, before I could fix another bug.

## [1.9.7](v1.9.6...v1.9.7) (2020-12-05) ### Bug Fixes * add duration.format to format a Duration ([#1202](#1202)) ([9a859a1](9a859a1)) * Add function handling for relativeTime.future and relativeTime.past ([#1197](#1197)) ([ef1979c](ef1979c)) * avoid install installed plugin ([#1214](#1214)) ([a92eb6c](a92eb6c)) * avoid memory leak after installing a plugin too many times ([b8d2e32](b8d2e32)) * fix diff bug when UTC plugin enabled ([#1201](#1201)) ([9544ed2](9544ed2)), closes [#1200](#1200) * fix startOf/endOf bug in timezone plugin ([#1229](#1229)) ([eb5fbc4](eb5fbc4)) * fix utc plugin diff edge case ([#1187](#1187)) ([971b3d4](971b3d4)) * update customParseFormat plugin to parse 2-digit offset ([#1209](#1209)) ([b56936a](b56936a)), closes [#1205](#1205) * Update timezone plugin type definition ([#1221](#1221)) ([34cfb92](34cfb92))

iamkun · 2020-12-05T14:58:22Z

🎉 This PR is included in version 1.9.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [1.9.7](iamkun/dayjs@v1.9.6...v1.9.7) (2020-12-05) ### Bug Fixes * add duration.format to format a Duration ([#1202](iamkun/dayjs#1202)) ([9a859a1](iamkun/dayjs@9a859a1)) * Add function handling for relativeTime.future and relativeTime.past ([#1197](iamkun/dayjs#1197)) ([ef1979c](iamkun/dayjs@ef1979c)) * avoid install installed plugin ([#1214](iamkun/dayjs#1214)) ([a92eb6c](iamkun/dayjs@a92eb6c)) * avoid memory leak after installing a plugin too many times ([b8d2e32](iamkun/dayjs@b8d2e32)) * fix diff bug when UTC plugin enabled ([#1201](iamkun/dayjs#1201)) ([9544ed2](iamkun/dayjs@9544ed2)), closes [#1200](iamkun/dayjs#1200) * fix startOf/endOf bug in timezone plugin ([#1229](iamkun/dayjs#1229)) ([eb5fbc4](iamkun/dayjs@eb5fbc4)) * fix utc plugin diff edge case ([#1187](iamkun/dayjs#1187)) ([971b3d4](iamkun/dayjs@971b3d4)) * update customParseFormat plugin to parse 2-digit offset ([#1209](iamkun/dayjs#1209)) ([b56936a](iamkun/dayjs@b56936a)), closes [#1205](iamkun/dayjs#1205) * Update timezone plugin type definition ([#1221](iamkun/dayjs#1221)) ([34cfb92](iamkun/dayjs@34cfb92))

## [1.9.7](iamkun/dayjs@v1.9.6...v1.9.7) (2020-12-05) ### Bug Fixes * add duration.format to format a Duration ([#1202](iamkun/dayjs#1202)) ([d682c45](iamkun/dayjs@d682c45)) * Add function handling for relativeTime.future and relativeTime.past ([#1197](iamkun/dayjs#1197)) ([2b0f4c2](iamkun/dayjs@2b0f4c2)) * avoid install installed plugin ([#1214](iamkun/dayjs#1214)) ([e19a1a6](iamkun/dayjs@e19a1a6)) * avoid memory leak after installing a plugin too many times ([9940980](iamkun/dayjs@9940980)) * fix diff bug when UTC plugin enabled ([#1201](iamkun/dayjs#1201)) ([09fbed8](iamkun/dayjs@09fbed8)), closes [#1200](iamkun/dayjs#1200) * fix startOf/endOf bug in timezone plugin ([#1229](iamkun/dayjs#1229)) ([fc285cc](iamkun/dayjs@fc285cc)) * fix utc plugin diff edge case ([#1187](iamkun/dayjs#1187)) ([b592a2e](iamkun/dayjs@b592a2e)) * update customParseFormat plugin to parse 2-digit offset ([#1209](iamkun/dayjs#1209)) ([166dcfe](iamkun/dayjs@166dcfe)), closes [#1205](iamkun/dayjs#1205) * Update timezone plugin type definition ([#1221](iamkun/dayjs#1221)) ([2f1cba8](iamkun/dayjs@2f1cba8))

edgarsn and others added 2 commits November 9, 2020 11:12

fix: Update lv (Latvian) locale relative time (iamkun#1192)

6545739

add function handling for future and past object

aa217be

iamkun force-pushed the dev branch from 6f21949 to 50f05ad Compare November 10, 2020 06:03

Ryan N Salim added 3 commits November 10, 2020 14:17

Add unit test

484558a

cosmetic

f69d708

clean up

ddbe33c

iamkun reviewed Nov 11, 2020

View reviewed changes

Merge branch 'dev' of github.com:iamkun/dayjs into fix/relativeTimeFu…

a06c6f4

…nction

iamkun merged commit ef1979c into iamkun:dev Nov 12, 2020

iamkun added the released label Dec 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add function handling for relativeTime.future and relativeTime.past #1197

fix: Add function handling for relativeTime.future and relativeTime.past #1197

drgx commented Nov 9, 2020

codecov bot commented Nov 9, 2020 •

edited

Loading

drgx commented Nov 9, 2020

iamkun commented Nov 10, 2020

drgx commented Nov 11, 2020

iamkun Nov 11, 2020

drgx Nov 12, 2020

iamkun commented Nov 12, 2020

skywritergr commented Nov 17, 2020

iamkun commented Nov 19, 2020

iamkun commented Dec 5, 2020

fix: Add function handling for relativeTime.future and relativeTime.past #1197

fix: Add function handling for relativeTime.future and relativeTime.past #1197

Conversation

drgx commented Nov 9, 2020

codecov bot commented Nov 9, 2020 • edited Loading

Codecov Report

drgx commented Nov 9, 2020

iamkun commented Nov 10, 2020

drgx commented Nov 11, 2020

iamkun Nov 11, 2020

Choose a reason for hiding this comment

drgx Nov 12, 2020

Choose a reason for hiding this comment

iamkun commented Nov 12, 2020

skywritergr commented Nov 17, 2020

iamkun commented Nov 19, 2020

iamkun commented Dec 5, 2020

codecov bot commented Nov 9, 2020 •

edited

Loading