fix: avoid memory leak after installing a plugin too many times

iamkun · Nov 23, 2020 · b8d2e32 · b8d2e32
1 parent a92eb6c
commit b8d2e32
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/index.js b/src/index.js
@@ -387,12 +387,10 @@ dayjs.prototype = proto;
 })
 
 dayjs.extend = (plugin, option) => {
-  if (plugin.installed) {
-    return dayjs
+  if (!plugin.$i) { // install plugin only once
+    plugin(option, Dayjs, dayjs)
+    plugin.$i = true
   }
-
-  plugin(option, Dayjs, dayjs)
-  plugin.installed = true
   return dayjs
 }
 

diff --git a/test/plugin/relativeTime.test.js b/test/plugin/relativeTime.test.js
@@ -120,6 +120,7 @@ it('Time from now with UTC', () => {
 
 it('Custom thresholds and rounding support', () => {
   expect(dayjs().subtract(45, 'm').fromNow()).toBe('an hour ago')
+  delete relativeTime.$i // this allow plugin to be installed again
   dayjs.extend(relativeTime, {
     rounding: Math.floor,
     thresholds: [