Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definition for offsetName #1221

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Conversation

nbudin
Copy link
Contributor

@nbudin nbudin commented Nov 15, 2020

The offsetName method for the timezone plugin was added in 1.9.0, but it's not in the TypeScript definitions. This adds it.

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #1221 (6587a82) into dev (971b3d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          174       174           
  Lines         1657      1657           
  Branches       377       377           
=========================================
  Hits          1657      1657           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971b3d4...6587a82. Read the comment docs.

@iamkun iamkun merged commit 34cfb92 into iamkun:dev Nov 16, 2020
@nbudin nbudin deleted the add-missing-offsetname branch November 16, 2020 17:21
iamkun pushed a commit that referenced this pull request Dec 5, 2020
## [1.9.7](v1.9.6...v1.9.7) (2020-12-05)

### Bug Fixes

* add duration.format to format a Duration ([#1202](#1202)) ([9a859a1](9a859a1))
* Add function handling for relativeTime.future and relativeTime.past ([#1197](#1197)) ([ef1979c](ef1979c))
* avoid install installed plugin ([#1214](#1214)) ([a92eb6c](a92eb6c))
* avoid memory leak after installing a plugin too many times ([b8d2e32](b8d2e32))
* fix diff bug when UTC plugin enabled ([#1201](#1201)) ([9544ed2](9544ed2)), closes [#1200](#1200)
* fix startOf/endOf bug in timezone plugin ([#1229](#1229)) ([eb5fbc4](eb5fbc4))
* fix utc plugin diff edge case ([#1187](#1187)) ([971b3d4](971b3d4))
* update customParseFormat plugin to parse 2-digit offset ([#1209](#1209)) ([b56936a](b56936a)), closes [#1205](#1205)
* Update timezone plugin type definition ([#1221](#1221)) ([34cfb92](34cfb92))
@iamkun
Copy link
Owner

iamkun commented Dec 5, 2020

🎉 This PR is included in version 1.9.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Dec 5, 2020
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.9.7](iamkun/dayjs@v1.9.6...v1.9.7) (2020-12-05)

### Bug Fixes

* add duration.format to format a Duration ([#1202](iamkun/dayjs#1202)) ([9a859a1](iamkun/dayjs@9a859a1))
* Add function handling for relativeTime.future and relativeTime.past ([#1197](iamkun/dayjs#1197)) ([ef1979c](iamkun/dayjs@ef1979c))
* avoid install installed plugin ([#1214](iamkun/dayjs#1214)) ([a92eb6c](iamkun/dayjs@a92eb6c))
* avoid memory leak after installing a plugin too many times ([b8d2e32](iamkun/dayjs@b8d2e32))
* fix diff bug when UTC plugin enabled ([#1201](iamkun/dayjs#1201)) ([9544ed2](iamkun/dayjs@9544ed2)), closes [#1200](iamkun/dayjs#1200)
* fix startOf/endOf bug in timezone plugin ([#1229](iamkun/dayjs#1229)) ([eb5fbc4](iamkun/dayjs@eb5fbc4))
* fix utc plugin diff edge case ([#1187](iamkun/dayjs#1187)) ([971b3d4](iamkun/dayjs@971b3d4))
* update customParseFormat plugin to parse 2-digit offset ([#1209](iamkun/dayjs#1209)) ([b56936a](iamkun/dayjs@b56936a)), closes [#1205](iamkun/dayjs#1205)
* Update timezone plugin type definition ([#1221](iamkun/dayjs#1221)) ([34cfb92](iamkun/dayjs@34cfb92))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.9.7](iamkun/dayjs@v1.9.6...v1.9.7) (2020-12-05)

### Bug Fixes

* add duration.format to format a Duration ([#1202](iamkun/dayjs#1202)) ([9a859a1](iamkun/dayjs@9a859a1))
* Add function handling for relativeTime.future and relativeTime.past ([#1197](iamkun/dayjs#1197)) ([ef1979c](iamkun/dayjs@ef1979c))
* avoid install installed plugin ([#1214](iamkun/dayjs#1214)) ([a92eb6c](iamkun/dayjs@a92eb6c))
* avoid memory leak after installing a plugin too many times ([b8d2e32](iamkun/dayjs@b8d2e32))
* fix diff bug when UTC plugin enabled ([#1201](iamkun/dayjs#1201)) ([9544ed2](iamkun/dayjs@9544ed2)), closes [#1200](iamkun/dayjs#1200)
* fix startOf/endOf bug in timezone plugin ([#1229](iamkun/dayjs#1229)) ([eb5fbc4](iamkun/dayjs@eb5fbc4))
* fix utc plugin diff edge case ([#1187](iamkun/dayjs#1187)) ([971b3d4](iamkun/dayjs@971b3d4))
* update customParseFormat plugin to parse 2-digit offset ([#1209](iamkun/dayjs#1209)) ([b56936a](iamkun/dayjs@b56936a)), closes [#1205](iamkun/dayjs#1205)
* Update timezone plugin type definition ([#1221](iamkun/dayjs#1221)) ([34cfb92](iamkun/dayjs@34cfb92))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this pull request Sep 12, 2024
## [1.9.7](iamkun/dayjs@v1.9.6...v1.9.7) (2020-12-05)

### Bug Fixes

* add duration.format to format a Duration ([#1202](iamkun/dayjs#1202)) ([d682c45](iamkun/dayjs@d682c45))
* Add function handling for relativeTime.future and relativeTime.past ([#1197](iamkun/dayjs#1197)) ([2b0f4c2](iamkun/dayjs@2b0f4c2))
* avoid install installed plugin ([#1214](iamkun/dayjs#1214)) ([e19a1a6](iamkun/dayjs@e19a1a6))
* avoid memory leak after installing a plugin too many times ([9940980](iamkun/dayjs@9940980))
* fix diff bug when UTC plugin enabled ([#1201](iamkun/dayjs#1201)) ([09fbed8](iamkun/dayjs@09fbed8)), closes [#1200](iamkun/dayjs#1200)
* fix startOf/endOf bug in timezone plugin ([#1229](iamkun/dayjs#1229)) ([fc285cc](iamkun/dayjs@fc285cc))
* fix utc plugin diff edge case ([#1187](iamkun/dayjs#1187)) ([b592a2e](iamkun/dayjs@b592a2e))
* update customParseFormat plugin to parse 2-digit offset ([#1209](iamkun/dayjs#1209)) ([166dcfe](iamkun/dayjs@166dcfe)), closes [#1205](iamkun/dayjs#1205)
* Update timezone plugin type definition ([#1221](iamkun/dayjs#1221)) ([2f1cba8](iamkun/dayjs@2f1cba8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants