Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-552: Android Sentry capture HTTP client errors #328

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion androidHyperskillApp/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ plugins {
kotlin("android")
kotlin("kapt")
kotlin("plugin.serialization")
alias(libs.plugins.sentry.androidGradle)
}

dependencies {
Expand Down
13 changes: 6 additions & 7 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ mokoResources = "0.20.1"
mokoKswift = "0.6.1"
ktlintRules = '1.0.0'
adapters = '1.1.1'
sentry = '5.7.3'
sentry = '6.12.1'
fragment = '1.4.1'
flipper = '0.148.0'
dokka = '1.7.20'
Expand Down Expand Up @@ -76,13 +76,15 @@ ktlintRules = { module = "ru.nobird.android.ktlint:rules", version.ref = "ktlint

android-security = { module = "androidx.security:security-crypto", version = "1.1.0-alpha03" }
android-material-progress-bar = { module = "me.zhanghai.android.materialprogressbar:library", version = "1.6.1" }
android-sentry = { module = "io.sentry:sentry-android", version.ref = "sentry" }
android-sentry-fragment = { module = "io.sentry:sentry-android-fragment", version.ref = "sentry" }
android-flipper = { module = "com.facebook.flipper:flipper", version.ref = "flipper" }
android-flipper-noop = { module = "com.facebook.flipper:flipper-noop", version.ref = "flipper" }
android-soloader = { module = "com.facebook.soloader:soloader", version = "0.10.1" }
android-parcelable = { module = "com.chrynan.parcelable:parcelable-core", version = "0.4.1" }

android-sentry = { module = "io.sentry:sentry-android", version.ref = "sentry" }
android-sentry-fragment = { module = "io.sentry:sentry-android-fragment", version.ref = "sentry" }
android-sentry-okhttp = { module = "io.sentry:sentry-android-okhttp", version.ref = "sentry" }

android-reactivex-rxandroid = { module = "io.reactivex.rxjava2:rxandroid", version = "2.1.0" }
android-reactivex-rxjava = { module = "io.reactivex.rxjava2:rxjava", version = "2.2.5" }
android-reactivex-rxkotlin = { module = "io.reactivex.rxjava2:rxkotlin", version = "2.3.0" }
Expand All @@ -95,7 +97,4 @@ android-desugar-jdk = { module = "com.android.tools:desugar_jdk_libs", version =

[bundles]
ktor-common = ['ktor-core', 'ktor-serialization', 'ktor-logging', 'ktor-contentNegotiation', 'ktor-serialization-json']
android-test = ['android-test-junit', 'android-test-runner', 'android-test-robolectric']

[plugins]
sentry-androidGradle = { id = "io.sentry.android.gradle", version = "3.0.1" }
android-test = ['android-test-junit', 'android-test-runner', 'android-test-robolectric']
1 change: 1 addition & 0 deletions shared/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ kotlin {
implementation(libs.ktor.android)
implementation(libs.kit.view.redux)
implementation(libs.android.lifecycle.viewmodel.ktx)
implementation(libs.android.sentry.okhttp)
}
}
val androidTest by getting {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package org.hyperskill.app.network

import io.ktor.client.HttpClient
import io.ktor.client.HttpClientConfig
import io.ktor.client.engine.okhttp.OkHttp
import io.sentry.HttpStatusCodeRange
import io.sentry.android.okhttp.SentryOkHttpInterceptor

@Suppress("FunctionName")
internal actual fun PreconfiguredPlatformHttpClient(block: HttpClientConfig<*>.() -> Unit): HttpClient =
HttpClient(OkHttp) {
apply(block)
engine {
addInterceptor(
SentryOkHttpInterceptor(
captureFailedRequests = true,
failedRequestStatusCodes = listOf(
HttpStatusCodeRange(400, 407),
HttpStatusCodeRange(409, 599)
)
XanderZhu marked this conversation as resolved.
Show resolved Hide resolved
)
)
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.hyperskill.app.network.injection
package org.hyperskill.app.network
XanderZhu marked this conversation as resolved.
Show resolved Hide resolved

import com.russhwolf.settings.Settings
import io.ktor.client.HttpClient
Expand Down Expand Up @@ -36,10 +36,10 @@ import org.hyperskill.app.core.remote.UserAgentInfo
import org.hyperskill.app.network.domain.model.NetworkClientType
import org.hyperskill.app.network.domain.model.NetworkEndpointConfigInfo

object NetworkBuilder {
internal object NetworkBuilder {
private const val AUTHORIZATION_HEADER = "Authorization"

internal fun buildEndpointConfigInfo(buildKonfig: BuildKonfig): NetworkEndpointConfigInfo =
fun buildEndpointConfigInfo(buildKonfig: BuildKonfig): NetworkEndpointConfigInfo =
NetworkEndpointConfigInfo(
baseUrl = buildKonfig.baseUrl,
host = buildKonfig.host,
Expand Down Expand Up @@ -73,7 +73,7 @@ object NetworkBuilder {
)
}

internal fun buildAuthorizedClient(
fun buildAuthorizedClient(
networkEndpointConfigInfo: NetworkEndpointConfigInfo,
userAgentInfo: UserAgentInfo,
json: Json,
Expand All @@ -83,7 +83,7 @@ object NetworkBuilder {
authorizationMutex: Mutex,
cookiesStorage: CookiesStorage
): HttpClient =
HttpClient {
PreconfiguredPlatformHttpClient {
val tokenSocialAuthClient = buildAuthClient(
NetworkClientType.SOCIAL,
networkEndpointConfigInfo,
Expand Down Expand Up @@ -182,14 +182,14 @@ object NetworkBuilder {
}
}

internal fun buildFrontendEventsUnauthorizedClient(
fun buildFrontendEventsUnauthorizedClient(
networkEndpointConfigInfo: NetworkEndpointConfigInfo,
userAgentInfo: UserAgentInfo,
json: Json,
buildVariant: BuildVariant,
cookiesStorage: CookiesStorage
): HttpClient =
HttpClient {
PreconfiguredPlatformHttpClient {
defaultRequest {
url {
protocol = URLProtocol.HTTPS
Expand Down Expand Up @@ -222,7 +222,7 @@ object NetworkBuilder {
buildVariant: BuildVariant,
credentials: String
) =
HttpClient {
PreconfiguredPlatformHttpClient {
defaultRequest {
headers {
append(AUTHORIZATION_HEADER, credentials)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package org.hyperskill.app.network

import io.ktor.client.HttpClient
import io.ktor.client.HttpClientConfig

@Suppress("FunctionName")
internal expect fun PreconfiguredPlatformHttpClient(block: HttpClientConfig<*>.() -> Unit): HttpClient
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import org.hyperskill.app.auth.domain.model.UserDeauthorized
import org.hyperskill.app.config.BuildKonfig
import org.hyperskill.app.core.domain.BuildVariant
import org.hyperskill.app.core.remote.UserAgentInfo
import org.hyperskill.app.network.NetworkBuilder
import org.hyperskill.app.network.domain.model.NetworkClientType
import org.hyperskill.app.network.domain.model.NetworkEndpointConfigInfo

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package org.hyperskill.app.network

import io.ktor.client.HttpClient
import io.ktor.client.HttpClientConfig
import io.ktor.client.engine.darwin.Darwin

@Suppress("FunctionName")
internal actual fun PreconfiguredPlatformHttpClient(block: HttpClientConfig<*>.() -> Unit): HttpClient =
HttpClient(Darwin) {
apply(block)
}