Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-552: Android Sentry capture HTTP client errors #328

Merged
merged 4 commits into from
Jan 25, 2023
Merged

ALTAPPS-552: Android Sentry capture HTTP client errors #328

merged 4 commits into from
Jan 25, 2023

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Jan 24, 2023 •
edited
Loading

YouTrack Issues:
#ALTAPPS-552

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • Sentry Performance Monitoring of screen loading is added for new screens;
  • View analytics events are added for new screens;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Add PreconfiguredHttpClient to create HttpClien on the platform and to be able to configure it for platform needs.
  • Add SentryOkHttpInterceptor to Android HttpClient
  • Update android centry lib
  • Disable auto network capturing on Android

@XanderZhu XanderZhu self-assigned this Jan 24, 2023
@XanderZhu XanderZhu added android Android module task ios iOS module task shared Shared module task labels Jan 24, 2023
@github-actions github-actions bot removed ios iOS module task android Android module task labels Jan 24, 2023
@ivan-magda ivan-magda added this to the 1.8 milestone Jan 24, 2023
@XanderZhu XanderZhu marked this pull request as ready for review January 24, 2023 08:42
@github-actions github-actions bot added the android Android module task label Jan 24, 2023
@XanderZhu XanderZhu added the ios iOS module task label Jan 24, 2023
@XanderZhu XanderZhu changed the title ALTAPPS-552/Android-Sentry-capture-HTTP-client-errors ALTAPPS-552: Android Sentry capture HTTP client errors Jan 24, 2023
ivan-magda
ivan-magda reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@ivan-magda ivan-magda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you tested this, were you able to see the HTTP client error in the Sentry console?

shared/src/commonMain/kotlin/org/hyperskill/app/network/NetworkBuilder.kt Show resolved Hide resolved
shared/src/commonMain/kotlin/org/hyperskill/app/network/PreconfiguredHttpClient.kt Outdated Show resolved Hide resolved
shared/src/androidMain/kotlin/org/hyperskill/app/network/PreconfiguredHttpClient.kt Show resolved Hide resolved
vladkash
vladkash approved these changes Jan 25, 2023 •
edited
Loading
View reviewed changes
@XanderZhu
Copy link
Contributor Author

XanderZhu commented Jan 25, 2023 •
edited
Loading

Are you tested this, were you able to see the HTTP client error in the Sentry console?

Yes, I tested this solution. Everything works.

@github-actions github-actions bot removed the ios iOS module task label Jan 25, 2023
@ivan-magda ivan-magda added the ready to pull Pull Request is ready to merge label Jan 25, 2023
@XanderZhu XanderZhu merged commit e281645 into develop Jan 25, 2023
@XanderZhu XanderZhu deleted the feature/ALTAPPS-552/Android-Sentry-capture-HTTP-client-errors branch January 25, 2023 20:23
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Feb 10, 2023
@ivan-magda ivan-magda mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

@vladkash vladkash vladkash approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task shared Shared module task
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@XanderZhu @ivan-magda @vladkash