feat(net): Split Ssl into SslClient and SslServer #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL libraries other than OpenSSL don't necessarily have the ability to easily create server and client side connections at the same time. This is backwards compatible due to blanket impls. Closes hyperium#756
| @@ -493,7 +527,7 @@ impl<S: NetworkStream> NetworkStream for HttpsStream<S> { | |||
|
|
|||
| /// A Http Listener over SSL. | |||
| #[derive(Clone)] | |||
| pub struct HttpsListener<S: Ssl> { | |||
| pub struct HttpsListener<S: SslServer> { | |||
There was a problem hiding this comment.
Will this break constructing HttpsListener for users who don't have the SslServer imported?
There was a problem hiding this comment.
I don't believe so. You don't need to have the trait imported for a type to implement it.
There was a problem hiding this comment.
Yeah, that sounds right on second thought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL libraries other than OpenSSL don't necessarily have the ability to
easily create server and client side connections at the same time. This
is backwards compatible due to blanket impls.
Closes #756