Openssl::with_cert_and_key certificate verification

[jimmycuadra]

I noticed that Openssl::with_cert_and_key disables certificate verification, shown below for convenience:

pub fn with_cert_and_key<C, K>(cert: C, key: K) -> Result<Openssl, SslError>
where C: AsRef<Path>, K: AsRef<Path> {
    let mut ctx = try!(SslContext::new(SslMethod::Sslv23));
    try!(ctx.set_cipher_list("DEFAULT"));
    try!(ctx.set_certificate_file(cert.as_ref(), X509FileType::PEM));
    try!(ctx.set_private_key_file(key.as_ref(), X509FileType::PEM));
    ctx.set_verify(SSL_VERIFY_NONE, None);
    Ok(Openssl { context: Arc::new(ctx) })
}

I'm guessing this is done because the expected use is for a server accepting connections from clients without client certificates. However, if someone uses this method for setting up a client to present a client certificate to a server, this will disable verification of the server's certificate.

Is my understanding here correct? If so, I think there should be two separate methods depending on whether it's intended for client or server use. At the very least, the documentation for the current method should make it very clear that it's not safe to use on the client side when using client certificates.

[seanmonstar]

Yes, your guess is correct. I assumed most people wanting an easy constructor with a cert and key were using it for a server, not a client.

[frewsxcv]

Related to #472

[frewsxcv]

If so, I think there should be two separate methods depending on whether it's intended for client or server use.

Ever since #757, there are now separate traits for server and client TLS use. That said, there still needs to exist a crate that actually verifies the certificates for this to be completed.

In my opinion, this issue can be closed as a duplicate of #472.

[jimmycuadra]

Isn't hostname verification different than certificate verification?

[sfackler]

The ssl feature has been removed, so I believe this issue can be closed.

[seanmonstar]

Indeed, SSL was removed, see #985.