Problems with PHP 7.2.34

[commercewerft]

Hi. I have problems to install valet+ on a fresh Macbook Pro with M1. When using the installation guide of valet+, step 3 with

brew install valet-php@7.2

fails with a make-error

/private/tmp/valet-php-7.2-20210228-18183-1ctjjm0/php-7.2.34/ext/intl/collator/collator_sort.c:349:26: error: use of undeclared identifier 'TRUE'
        collator_sort_internal( TRUE, INTERNAL_FUNCTION_PARAM_PASSTHRU );
                                ^
/private/tmp/valet-php-7.2-20210228-18183-1ctjjm0/php-7.2.34/ext/intl/collator/collator_sort.c:543:26: error: use of undeclared identifier 'FALSE'
        collator_sort_internal( FALSE, INTERNAL_FUNCTION_PARAM_PASSTHRU );

brew install valet-php@7.3 and 7.4 works.

Some ideas?

[leewillis77]

I'm seeing similar on PHP 5.6:

        ZVAL_STRINGL( utf8_zval, str, str_len, FALSE );
                                               ^
/private/tmp/valet-php-5.6-20210302-32344-1asb4ry/php-5.6.40/ext/intl/collator/collator_convert.c:235:53: error: use of undeclared identifier 'FALSE'
        ZVAL_STRINGL( zstr, (char*)ustr, UBYTES(ustr_len), FALSE );
                                                           ^
/private/tmp/valet-php-5.6-20210302-32344-1asb4ry/php-5.6.40/ext/intl/collator/collator_convert.c:310:53: error: use of undeclared identifier 'FALSE'
        ZVAL_STRINGL( zstr, (char*)ustr, UBYTES(ustr_len), FALSE );
                                                           ^
5 errors generated.
make: *** [ext/intl/collator/collator_convert.lo] Error 1
/private/tmp/valet-php-5.6-20210302-32344-1asb4ry/php-5.6.40/ext/intl/collator/collator_locale.c:69:52: error: use of undeclared identifier 'TRUE'
        RETVAL_STRINGL( locale_name, strlen(locale_name), TRUE );
                                                          ^
1 error generated.
make: *** [ext/intl/collator/collator_locale.lo] Error 1

[leewillis77]

I see the same with most versions actually. Seems it's a PHP incompatibility with icu4c 68.1:
https://bugs.php.net/bug.php?id=80310