Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

128 provenance info #463

Merged
merged 4 commits into from
Aug 8, 2023
Merged

128 provenance info #463

merged 4 commits into from
Aug 8, 2023

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jul 12, 2023

The indexing breaks because of the last commit. I am not sure why. I add two elements to mainEntityOfPage. It could be that used is a weird array. Could you have a look. see #128

@TobiasNx TobiasNx changed the base branch from master to useFixInsteadOfMorph July 12, 2023 08:29
@fsteeg
Copy link
Member

fsteeg commented Jul 13, 2023

Didn't look closely yet, but there are a lot of failing tests. Also there are conflicts, so maybe something went wrong when branching off or something, and this is not actually the correct state? I'd suggest resolving the conflicts first and then we can take a closer look at the failures.

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Jul 18, 2023

I merged the master into this. The error still there. I assume that the old version of elasticSearch is not able to work with this mixed array:

"used": [
		{
			"id": "http://services.dnb.de/sru/bib?operation=searchRetrieve&query=isl%3DDE-294&recordSchema=PicaPlus-xml&version=1.1",
			"sourceOrganisation": {
				"id": "https://sigel.staatsbibliothek-berlin.de/vergabe/isil/",
				"label": "Deutsche ISIL-Agentur und Sigelstelle an der Staatsbibliothek zu Berlin"
				}
		},
		"https://github.com/metafacture/metafacture-core",
		"https://github.com/hbz/lobid-organisations/blob/master/conf/fix-sigel.fix",
		"https://github.com/hbz/lobid-organisations/blob/master/conf/fix-enriched.fix"
	]

@TobiasNx TobiasNx assigned dr0i and unassigned fsteeg Aug 7, 2023
@TobiasNx TobiasNx requested a review from dr0i August 8, 2023 07:52
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Aug 8, 2023

ElasticSearch-Docu says: Arrays with a mixture of data types are not supported: [ 10, "some string" ]

That could be the problem, but I dont know why this is possible in ElasticSearch with OERSI: See @context here

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Aug 8, 2023

@dr0i can you help?

@acka47
Copy link
Contributor

acka47 commented Aug 8, 2023

I dont know why this is possible in ElasticSearch with OERSI: See @context here

I think this is due to the fact that @context is not indexed.

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Aug 8, 2023

@acka47 and I decided to kick out the metafacture links to only use the sourceData as object for now.

They created problems for the  elasticSearch
@TobiasNx TobiasNx assigned TobiasNx and unassigned dr0i Aug 8, 2023
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Aug 8, 2023

like this:


"used": [
		{
			"id": "http://services.dnb.de/sru/bib?operation=searchRetrieve&query=isl%3DDE-294&recordSchema=PicaPlus-xml&version=1.1",
			"sourceOrganisation": {
				"id": "https://sigel.staatsbibliothek-berlin.de/vergabe/isil/",
				"label": "Deutsche ISIL-Agentur und Sigelstelle an der Staatsbibliothek zu Berlin"
				}
	]

@TobiasNx TobiasNx merged commit df0ad93 into useFixInsteadOfMorph Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants