Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate morph into fix and switch to fix #450

Merged
merged 106 commits into from
Sep 18, 2023
Merged

Translate morph into fix and switch to fix #450

merged 106 commits into from
Sep 18, 2023

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jun 12, 2023

Related to #452 and replaces #454

This PR replaces the morph transformation with a fix transformation.

@acka47 and @fsteeg could you have a look at GUI of test.lobid.org/organisations and the json-data there. I finished the transformation i my opinion.

I also included fixes for:
#361 - added gndId and links to lobid-gnd
#411 - added sigils
#458 - added an note[]-element
#457 and #76 added replacedBy, replaces and dissolutionDate
#99 added libraries.org links
#269 removed test entries
#309 added parentOrganisation
#383 added wikidata
#428 use https for isil registry links
#128 add provenance Info but without links to metafacture since the early version breaks elasticSearch

@dr0i
Copy link
Member

dr0i commented Aug 14, 2023

Offline agreed to more checking functionality vs code review (which is a bit unhandy re amount of commits and changed files).

  • test nwbib and lobid-resource with these new organisations data GUI-wise (e.g. https://test.nwbib.de/99371956100006441 => "Bestand in 1 Bibliothek:" ->"Bonn" with OSM-Tile)
  • do updates via OAI-PMH work?
  • are ntriples still served

@dr0i
Copy link
Member

dr0i commented Aug 15, 2023

Updates seems to work. After bash -x cron.sh the resource http://test.lobid.org/organisations/DE-4229#! with "dateCreated":"15-08-23" exists in test system (and not yet in production).
So I think this PR is fine 👍

TobiasNx and others added 6 commits August 22, 2023 14:29
Until we fix or change the OAI-PMH Update process that does not initate new intervals after the first interval
I suggest push the interval.size to 2000 until we change the OAI-PMH-Process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants