Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/rds: move mysql tarball to ./aws/testdata #13333

Merged
merged 1 commit into from
May 19, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented May 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13308

Release note for CHANGELOG:

NONE

Output from acceptance testing:

❯ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBInstance_S3Import'
(fails as it does on CI)

❯ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_s3Restore'
(fails as it does on CI)

@bflad please don't ask me to fix the failures on TC 😿

EDIT: woops only just realized we are moving all these to testdata/

@appilon appilon requested a review from a team May 15, 2020 04:49
@ghost ghost added service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels May 15, 2020
@appilon appilon changed the title Move mysql tarball to ./aws/test-fixtures Move mysql tarball to ./aws/testdata May 15, 2020
@appilon appilon changed the title Move mysql tarball to ./aws/testdata service/rds: move mysql tarball to ./aws/testdata May 15, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (yeah, unfortunately those acceptance test failures have been around for awhile, its probably worth opening up an issue so someone can potentially fix them)

@appilon appilon merged commit 76b3d09 into master May 19, 2020
@appilon appilon deleted the appilon/move-fixtures branch May 19, 2020 16:23
@appilon appilon added this to the v2.63.0 milestone May 20, 2020
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
@ghost
Copy link

ghost commented Jun 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants