Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Test File Assets to aws/testdata Directory #13308

Closed
bflad opened this issue May 13, 2020 · 1 comment
Closed

Migrate Test File Assets to aws/testdata Directory #13308

bflad opened this issue May 13, 2020 · 1 comment
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@bflad
Copy link
Contributor

bflad commented May 13, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently there are multiple places where testing file assets, such as archives, are located:

files
└── mysql-5-6-xtrabackup.tar.gz
aws/test-fixtures
├── cloudformation-template.json
├── cloudformation-template.yaml
├── cloudfront-public-key.pem
├── emr_configurations.json
├── iam-ssl-unix-line-endings.pem
├── iam-ssl-windows-line-endings.pem.winfile
├── iot-csr.pem
├── lambda_basic_authorizer.zip
├── lambda_confirm_sns.zip
├── lambda_elb.zip
├── lambda_func.js
├── lambda_func_modified.js
├── lambda_invocation.js
├── lambda_invocation.zip
├── lambdapinpoint.zip
├── lambdatest.zip
├── lambdatest_modified.zip
├── public-ssh-key.pub
├── python-v1.zip
├── sagemaker-tensorflow-serving-test-model.tar.gz
├── saml-metadata-modified.xml
├── saml-metadata.xml
├── transfer-ssh-rsa-key
├── worklink-device-ca-certificate.pem
└── worklink-website-certificate-authority-association.pem

These should all be migrated to a testdata subdirectory of the package being tested, per Go convention and to fix issues with the upcoming binary testing driver. In the future where the testing is per-service, additional accommodations will need to be made for that scenario to keep everything referenced in a subdirectory for the binary testing driver.

Note: Before moving them, we'll probably want to ensure there are not open PRs for the references or files themselves.

References

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels May 13, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

No branches or pull requests

3 participants