Add GRPC Stdio Copying system #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A note to any reviewers, some of the comments indicate that this isn't necessarily fully implemented. |
yurishkuro
reviewed
Feb 16, 2020
| logger.Error("Experienced issue in gRPC copier", "error", e) | ||
| return | ||
| } | ||
| writer.Write(response.Data) |
There was a problem hiding this comment.
this would be better placed inside case nil:
|
I wonder, wouldn't it be easier for the client to simply read the stdout/err of the child process, split on |
|
Superseded by #135. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.