Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdout/stderr sync not implemented for gRPC storage plugins #2071

Closed
petermetz opened this issue Feb 16, 2020 · 4 comments
Closed

stdout/stderr sync not implemented for gRPC storage plugins #2071

petermetz opened this issue Feb 16, 2020 · 4 comments
Labels

Comments

@petermetz
Copy link

Requirement - what kind of business use case are you trying to solve?

Need to propagate logs of a storage plugin gRPC server (implemented not in Go) to the OS stdout+stderr so that logs of the storage plugin can be analyzed.

Problem - what in Jaeger blocks you from solving the requirement?

go-plugin doesn't sync stdout/stderr so there's no way to get the logs of the plugin (logging to file is not feasible in the environment)

Proposal - what do you suggest to solve the problem or improve the existing situation?

I'm not a 100% sure how to fix it until go-plugin fixes in on their side, but figured maybe a workaround could be added in Jaeger because the relevant go-plugin issue doesn't seem to be getting a fix anytime soon:

hashicorp/go-plugin#93

Any open questions to address

N/A

@ghost ghost added the needs-triage label Feb 16, 2020
@yurishkuro
Copy link
Member

I don't think we can build anything special in Jaeger, we're fully delegating to go-plugin to start & manage the child process containing the plugin.

See also hashicorp/go-plugin#113 (comment)

@yurishkuro yurishkuro added wishlist Feature that maintainers consider valuable but cannot prioritize due to other commitments and removed needs-triage labels Feb 16, 2020
@petermetz
Copy link
Author

I don't think we can build anything special in Jaeger, we're fully delegating to go-plugin to start & manage the child process containing the plugin.

See also hashicorp/go-plugin#113 (comment)

@yurishkuro Makes sense.
Now that hashicorp/go-plugin#135 is done, can the go-plugin version used by Jaeger be updated? It's been a while since we spoke about this so apologies if this was already taken care of in one of the releases since February (in which case this issue can be closed)

@yurishkuro
Copy link
Member

Jaeger is currently on go-plugin v1.0.1, but hashicorp/go-plugin#135 was released in v1.2, from what I understand. We can try upgrading.

@yurishkuro
Copy link
Member

closing as we plan to sunset go-plugin based extensions #4647

@yurishkuro yurishkuro closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@yurishkuro yurishkuro added wontfix and removed wishlist Feature that maintainers consider valuable but cannot prioritize due to other commitments labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants