Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated dependency upgrades #911

Closed
wants to merge 5 commits into from
Closed

Conversation

tschaume
Copy link
Collaborator

@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from adba088 to c281b8f Compare September 25, 2023 08:05
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from cbfd5aa to 068f0fb Compare October 16, 2023 08:05
@ardunn
Copy link
Contributor

ardunn commented Oct 19, 2023

@tschaume is this the result of an automated workflow or did you open this PR manually? I'm still a bit out of the loop on how the new dependencies manager works, even after reading through the new workflow yaml in .github...

@ml-evs
Copy link
Collaborator

ml-evs commented Oct 19, 2023

I believe this is automatic, but currently uses @tschaume's GitHub PAT to make the PR. I don't know why tests don't run automatically for these PRs.

Just to add that there are still outstanding issues from the last dep upgrade where some featurizers are no longer consistent/stable (RDFs are all NaNs, for example): #910 (comment) I fixed most things in #912 but cannot spend any more time on this myself at the moment.

@tschaume
Copy link
Collaborator Author

@ardunn yes, these PRs are created automatically to keep the requirements files up-to-date. pip-tools is used to create requirements files that contain the latest conflict-free versions of all the dependencies. The tests should then run on these PRs (and did for #886) in order to see if there any issues caused by upgrading the dependencies. This approach originated in #880 where I also added a link with more info about the process. HTH.

@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from 79dfd71 to 1d36e52 Compare November 6, 2023 08:05
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from 91a24b8 to 79ef62d Compare November 20, 2023 08:05
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from 8c7754d to 8836b87 Compare December 11, 2023 08:05
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from fd9b812 to 19ee5f7 Compare December 25, 2023 08:05
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from c703c93 to 8795430 Compare January 15, 2024 08:05
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from 7fda8a3 to 9f1628a Compare January 29, 2024 08:05
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 3 times, most recently from 0e66a3e to b2aa6f6 Compare February 12, 2024 08:05
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from a533fc2 to 0aa8534 Compare February 26, 2024 08:04
@github-actions github-actions bot force-pushed the auto-dependency-upgrades branch 2 times, most recently from b2f34e6 to cc657b5 Compare March 11, 2024 08:05
@ml-evs
Copy link
Collaborator

ml-evs commented Mar 26, 2024

I think GH actions won't run tests on PRs that end with commits from people without GH accounts (see blank details on requirements commits above). I don't have admin powers to update this to use my token/committer details. I'm going to extract these changes into a fresh PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants