Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pandas~=1.5 pin #910

Closed
wants to merge 1 commit into from
Closed

remove pandas~=1.5 pin #910

wants to merge 1 commit into from

Conversation

tschaume
Copy link
Collaborator

@tschaume tschaume commented Sep 6, 2023

@ml-evs we would like to upgrade to pandas 2 for MP. Would it be possible to remove the pandas requirement in matminer?

@ml-evs we would like to upgrade to pandas 2 for MP. Would it be possible to remove the `pandas` requirement in matminer?
@tschaume tschaume self-assigned this Sep 6, 2023
@ml-evs
Copy link
Collaborator

ml-evs commented Sep 6, 2023

Could you also update it in the pinned ci versions so we know what works/what doesn't? I didn't add the upper bound but presumably something breaks without it

I stalled in my other dep update PR, can't remember if I tried to update pandas there

@ml-evs
Copy link
Collaborator

ml-evs commented Sep 6, 2023

Could you also update it in the pinned ci versions so we know what works/what doesn't? I didn't add the upper bound but presumably something breaks without it

I stalled in my other dep update PR, can't remember if I tried to update pandas there

Feel free to merge this in the meantime btw

@tschaume
Copy link
Collaborator Author

tschaume commented Sep 6, 2023

@ml-evs I ran the upgrade-dependencies action and merged the update requirements files (see #891).

@tschaume tschaume closed this Sep 6, 2023
@tschaume tschaume deleted the rm-pandas-pin branch September 6, 2023 17:54
@ml-evs
Copy link
Collaborator

ml-evs commented Sep 6, 2023

Thanks, the issue I had with that PR is that the tests were never actually running in the CI, and several changes were needed to get them to pass in #908, I can take a look at this again this month if I get time

@ml-evs
Copy link
Collaborator

ml-evs commented Sep 11, 2023

@tschaume just back from holiday and have checked this, lots of test failures and some incompatibility with pandas 2 at the moment, have made some changes in #912 but there are still lots of spurious test failures. If matminer is in use at MP would someone be able to take a look at these to accommodate the deps update?

@tschaume
Copy link
Collaborator Author

@ml-evs Thanks! We unfortunately don't have any bandwidth to help with the matminer development or maintenance. @ardunn any chance you have some cycles left over to look at this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants