Revert "dns: stop polling for updates; use UpdateState API" #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e5e980f.
|
DNS's LookupTXT() fails with NotFound error when txt record doesn't exist for the host. With the change in #3165, this will cause a serviceconfig.ParseResult with Err set to non-nil. The service config handling for service config with error seems to be working as intended. The fix should be to not return an error if LookupTXT failed with NotFound. |
easwars
approved these changes
Nov 26, 2019
This was referenced Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3165
The change breaks clients using DNS resolver, including all interop tests: grpc/grpc#21301