Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: service config should be nil when lookupTXT returns NotFound #3212

Closed
wants to merge 1 commit into from
Closed

dns: service config should be nil when lookupTXT returns NotFound #3212

wants to merge 1 commit into from

Conversation

menghanl
Copy link
Contributor

Service config should only be an error if lookupTXT failed due to other
errors, like timeout.

@menghanl
dns: service config should be nil when lookupTXT returns NotFound
61bdf99 
Service config should only be an error if lookupTXT failed due to other
errors, like timeout.
@menghanl menghanl mentioned this pull request Nov 26, 2019
Merged
@menghanl
Copy link
Contributor Author

This PR needs changes in #3165, which was reverted in #3213.

@dfawley dfawley mentioned this pull request Dec 4, 2019
Merged
@menghanl menghanl closed this Dec 5, 2019
@menghanl menghanl deleted the dns_txt_failure branch December 5, 2019 22:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars Awaiting requested review from easwars

@dfawley dfawley Awaiting requested review from dfawley

Assignees

@easwars easwars

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@menghanl @easwars @dfawley