Multi-target .NET 5 #987
Multi-target .NET 5 #987
Conversation
JamesNK
force-pushed
the
jamesnk/multitarget-net5
branch
from
ee4ef37
to
6ec8531
Compare
|
Interop tests are failing because of grpc/grpc#23523 |
JamesNK
force-pushed
the
jamesnk/multitarget-net5
branch
3 times, most recently
from
e6710f2
to
a3295c1
Compare
|
Everything is passing apart from interop tests @jtattermusch When you have time can you help with grpc/grpc#23523. Need to update grpc/grpc so changing the framework doesn't change the path and break interop tests. |
JamesNK
force-pushed
the
jamesnk/multitarget-net5
branch
from
a3295c1
to
bd424f9
Compare
There was a problem hiding this comment.
LGTM for adding net5 targets, @JunTaoLuo can you please review the rest of the changes in detail?
global.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "3.1.300" | |||
| "version": "5.0.100-rc.1.20367.2" | |||
There was a problem hiding this comment.
should we explicitly set rollForward ?
There was a problem hiding this comment.
I don't know. I have used that setting.
Is it required? I haven't had trouble with installing newer versions yet.
JamesNK
force-pushed
the
jamesnk/multitarget-net5
branch
3 times, most recently
from
df49146
to
78b9dcc
Compare
JamesNK
force-pushed
the
jamesnk/multitarget-net5
branch
from
9ad48fb
to
0a17f36
Compare
JamesNK
force-pushed
the
jamesnk/multitarget-net5
branch
from
0a17f36
to
60ad9ca
Compare
|
@JunTaoLuo This is ready to review |
|
|
||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | ||
| <!-- | ||
| TODO(JamesNK): SDK temporarily changed from Microsoft.NET.Sdk.Worker to Microsoft.NET.Sdk.Web |
There was a problem hiding this comment.
File an issue so we don't forget to do this in the future?
src/Grpc.Net.Client/GrpcChannel.cs
Outdated
| using Grpc.Core; | ||
| using Grpc.Net.Client.Internal; | ||
| using Grpc.Net.Compression; | ||
| using Microsoft.Extensions.Logging; | ||
| using Microsoft.Extensions.Logging.Abstractions; | ||
| using System; |
src/Grpc.AspNetCore.Server/Internal/CallHandlers/ServerCallHandlerBase.cs
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/multitarget-net5
branch
from
4d4d518
to
cbb059a
Compare
Testing multi-target packages on .NET 5
Soon the client and server will start using .NET 5 specific APIs, e.g. configuring the client to create a connections when there are more than 100 concurrent requests.