Skip to content

Commit

Permalink
More fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesNK committed Aug 2, 2020
1 parent fa501ca commit df49146
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<LangVersion>8.0</LangVersion>
<Nullable>enable</Nullable>

<!-- Fix CS1900 error in .NET 5 preview -->
<AnalysisLevel>4</AnalysisLevel>
</PropertyGroup>

</Project>
2 changes: 2 additions & 0 deletions src/Grpc.Net.Client.Web/GrpcWebHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,9 @@ private async Task<HttpResponseMessage> SendAsyncCore(HttpRequestMessage request
// return content once the entire response has been downloaded. This breaks server streaming.
//
// https://github.com/mono/mono/issues/18718
#pragma warning disable CS0618 // Type or member is obsolete
request.Properties[WebAssemblyEnableStreamingResponseKey] = true;
#pragma warning restore CS0618 // Type or member is obsolete

if (HttpVersion != null)
{
Expand Down
2 changes: 2 additions & 0 deletions test/Grpc.Net.Client.Tests/Web/GrpcWebHandlerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ private class TestHttpHandler : HttpMessageHandler
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
RequestVersion = request.Version;
#pragma warning disable CS0618 // Type or member is obsolete
if (request.Properties.TryGetValue(GrpcWebHandler.WebAssemblyEnableStreamingResponseKey, out var enableStreaming))
#pragma warning restore CS0618 // Type or member is obsolete
{
WebAssemblyEnableStreamingResponse = (bool)enableStreaming!;
}
Expand Down

0 comments on commit df49146

Please sign in to comment.