This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Add new members for vt elements in vts dictionary #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add get_dependencies_vt_as_xml_str() Change signature of add_vt(): Add vt_dependencies paramater. Dependencies are now an explicit element of vt and use the vt_id to reference them. empty static method to be overriding by the wrapper class.
Add get_*_vt_as_xml_str() Change signature of add_vt() This tags are now an explicit element of vt and use the vt_id to reference them. Add empty static method to be overriding by the wrapper class.
Add get_solution_vt_as_xml_str() Change signature of add_vt() This tag is now an explicit element of vt. Add an empty static method to be overriding by the wrapper class.
Add get_detection_vt_as_xml_str()
Change signature of add_vt()
This tag is now an explicit element of vt with qod_type as attributr.
Add an empty static method to be overriding by the wrapper class.
Also fix the code, since there is either qod or qod_type for an vt, but not always a vuldetect.
Add get_severities_vt_as_xml_str() Change signature of add_vt() Severity related tags are now part of an explicit element of vt. Add an empty static method to be overriding by the wrapper class.
jjnicola
force-pushed
the
vt-elements
branch
2 times, most recently
from
4994caf
to
5d66a63
Compare
jjnicola
force-pushed
the
vt-elements
branch
from
f53ae6a
to
89614f2
Compare
This allow to know the vt_id in the override method to improve debugging in case it is necessary. Update unit test method as well.
janowagner
approved these changes
Nov 20, 2018
There was a problem hiding this comment.
I have tested the patch in conjunction with PR #33 for ospd-openvas successfully.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new explicit vt members (summary, affected, impact, insight, solution, detection, severities)
Update documentation
Add unit tests.