Move members from custom element to vt element inside the vts dictionary #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the custom element. It will be used in case of no qod_type. It returns the detection element at least with qod or qod_type, since it is possible that there is no vuldetect tag for a script.
The qod/qod_type tag was moved in vts dictionary. It is not under custom member anymore.
Members of the dict are cvss_base_vector, cvss_base from the script tags, and also cvss_type and cvss_origin. Add get_severities_vt_as_xml_str(), which returns a severity xml element in string format. Remove unused get_nvt_severity() method. Fix severities in results.
jjnicola
force-pushed
the
vt-elements
branch
from
f05664a
to
1f725b4
Compare
Necessary to improve debugging. Before was not possible to know the problematic vt. Improve logging for get_refs_vt_as_xml_str and get_severities_vt_as_xml_str
janowagner
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several tags which were before in custom element, are now an explicit member of each vt.
Depends on PR greenbone/ospd#73