Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use undefined for empty #4046

Merged
merged 1 commit into from
May 8, 2024

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Apr 5, 2024

As convention, we will lazily instantiate arrays/sets when adding the first item.

This applies to arrays/sets on execution/incremental context, as well as the second member of the GraphQLWrappedResult tuple holding the array of incremental data records.

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 37f6e88
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/663bd21e5a222a0008e8a345
😎 Deploy Preview https://deploy-preview-4046--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 5, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR requested review from robrichard and a team April 5, 2024 14:16
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Apr 5, 2024
@yaacovCR yaacovCR force-pushed the use-undefined-for-empty branch 2 times, most recently from 2e2b1b2 to 1ce2956 Compare April 7, 2024 10:15
@yaacovCR
Copy link
Contributor Author

yaacovCR commented Apr 7, 2024

image

@yaacovCR yaacovCR changed the title use undefined for empty perf: use undefined for empty Apr 7, 2024
yaacovCR added a commit that referenced this pull request Apr 18, 2024
following graphql/graphql-spec#1077

now part of the following PR stack, with the laters PRs extracted from
this one

#4026: incremental: introduce GraphQLWrappedResult to avoid filtering
#4050: perf: allow skipping of field plan generation
#4051: perf: introduce completePromisedListItemValue
#4052: refactor: introduce completeIterableValue
#4053: perf: optimize completion loops
#4046: perf: use undefined for empty
@yaacovCR yaacovCR force-pushed the use-undefined-for-empty branch 2 times, most recently from 195c372 to 300af34 Compare April 24, 2024 16:36
@yaacovCR
Copy link
Contributor Author

yaacovCR commented May 8, 2024

took out dependence on #4053

image

@yaacovCR yaacovCR merged commit 92f9bb0 into graphql:main May 8, 2024
20 checks passed
@yaacovCR yaacovCR deleted the use-undefined-for-empty branch May 8, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants