Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental: use filtering instead of GraphQLResult #4043

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Apr 5, 2024

now that filtering has been removed from #4026, this draft PR could be checked out to see what it would look like to reintroduce it.

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit e5c9a71
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6629356d8c96b60008b37541
😎 Deploy Preview https://deploy-preview-4043--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 5, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor Author

yaacovCR commented Apr 7, 2024

image

use-undefined-for-empty corresponds to #4046

the above stats show that with filtering, we have significant performance boost for synchronous lists, and we have maintained parity even for asynchronous lists

@yaacovCR yaacovCR changed the title add back filtering incremental: add back filtering Apr 8, 2024
@yaacovCR yaacovCR changed the title incremental: add back filtering incremental: use filtering instead of GraphQLResult Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant