Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Fixing double run when creating a PR #2863

Closed
wants to merge 3 commits into from

Conversation

gagoar
Copy link

@gagoar gagoar commented Nov 27, 2020

Currently, the workflow runs twice every PR. This is caused by push and on pull_request events.
Sadly the documentation says that it will be an or.

But in practice, this triggers twice.

Alternatively, we could just leave push

on:  push

this is visible when inspecting some of the PR's

image

every step produces 2 runs (one for push the other for pull_request)
example for pull request
example for push

this is also visible in #2757
image

@gagoar gagoar changed the title [workflow] Fixing double run and basic naming [workflow] Fixing double run when creating a PR Nov 27, 2020
@gagoar
Copy link
Author

gagoar commented Nov 27, 2020

I have a check failing that I can't reproduce. also I'm not changing code.


> graphql@15.4.0 prettier:check /base/graphql-js
> prettier --check .

Checking formatting...
All matched files use Prettier code style!

@IvanGoncharov
Copy link
Member

I have a check failing that I can't reproduce. also I'm not changing code.

@gagoar In logs you will see:
image

@gagoar
Copy link
Author

gagoar commented Nov 30, 2020

I have a check failing that I can't reproduce. also I'm not changing code.

@gagoar In logs you will see:
image

I've run this on my computer but I can't seem to see what's the wrong part with what I've changed. can you tell me what is wrong?

also what I've changes can't be written differently

Base automatically changed from master to main January 27, 2021 11:10
@yaacovCR
Copy link
Contributor

This can probably be closed considering all the improvements by @IvanGoncharov within our use of GitHub actions. Feel free to reopen as necessary.

@yaacovCR yaacovCR closed this May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants