Support returning async iterables from resolver functions #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: feature 🚀
|
@robrichard Since ATM we are using a very similar algorithm I'm worried that we will also have memory leak: |
IvanGoncharov
force-pushed
the
asynciteratable
branch
2 times, most recently
from
f612eb6
to
d25cf40
Compare
Merged
robrichard
force-pushed
the
asynciteratable
branch
2 times, most recently
from
f1ddb83
to
10f12a1
Compare
robrichard
force-pushed
the
asynciteratable
branch
4 times, most recently
from
e93482c
to
b393729
Compare
robrichard
force-pushed
the
asynciteratable
branch
2 times, most recently
from
6415aa1
to
93bd84a
Compare
dnalborczyk
reviewed
Sep 23, 2021
robrichard
force-pushed
the
asynciteratable
branch
2 times, most recently
from
2153dda
to
fa38819
Compare
robrichard
force-pushed
the
asynciteratable
branch
3 times, most recently
from
c2d20a1
to
971ce43
Compare
robrichard
force-pushed
the
asynciteratable
branch
4 times, most recently
from
e8c1a70
to
09d56d6
Compare
robrichard
force-pushed
the
asynciteratable
branch
from
09d56d6
to
8c6d731
Compare
robrichard
force-pushed
the
asynciteratable
branch
from
63e8c73
to
7e793c1
Compare
|
The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
robrichard
force-pushed
the
asynciteratable
branch
from
7e793c1
to
4aa22c4
Compare
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
robrichard
force-pushed
the
asynciteratable
branch
from
4aa22c4
to
a49dec8
Compare
robrichard
force-pushed
the
asynciteratable
branch
from
a49dec8
to
cddf009
Compare
robrichard
force-pushed
the
asynciteratable
branch
from
cddf009
to
1a84993
Compare
yaacovCR
requested changes
Apr 24, 2022
There was a problem hiding this comment.
My review (requested by @saihaj ) is basically that we should allow resolvers to return async iterables of iterables, not of individual items. See graphql/defer-stream-wg#38
robrichard
force-pushed
the
asynciteratable
branch
from
1a84993
to
6aeb21c
Compare
robrichard
force-pushed
the
asynciteratable
branch
2 times, most recently
from
b742343
to
92ef2af
Compare
robrichard
force-pushed
the
asynciteratable
branch
from
92ef2af
to
fd12a27
Compare
robrichard
force-pushed
the
asynciteratable
branch
3 times, most recently
from
ab235c2
to
18a6145
Compare
yaacovCR
approved these changes
May 29, 2022
robrichard
force-pushed
the
asynciteratable
branch
from
18a6145
to
58c72ab
Compare
|
We decided at last js-wg to give this a few days, but it seems to have slipped. It looks good to me. @IvanGoncharov @saihaj ? |
saihaj
approved these changes
Jun 14, 2022
robrichard
force-pushed
the
asynciteratable
branch
from
58c72ab
to
dc1d8b4
Compare
Support returning async iterables from resolver functions
robrichard
force-pushed
the
asynciteratable
branch
from
dc1d8b4
to
2826e53
Compare
|
@robrichard Merged, sorry for the long overdue review. |
angelini
pushed a commit
to gadget-inc/graphql-js
that referenced
this pull request
Aug 30, 2023
Co-authored-by: Rob Richard <rob@1stdibs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2712
Depends on #3134