Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert flow types to TS #2828

Closed
wants to merge 65 commits into from
Closed

Convert flow types to TS #2828

wants to merge 65 commits into from

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Oct 27, 2020

Summary

Convert all the .js to .ts and fix all syntax related issues that exist because of Flow and TypeScript.

Action items Based on #2828 (comment)
For @IvanGoncharov

For @saihaj

  • Compare and remove .d.ts
  • Convert flow types to TS #2828 (comment)
  • Remove Flow infrastructure, even integration test (remove in one commit and split if requested)
  • Convert type to interfaces
  • Enable as much as possible ESLint rules

Fix no redeclare src/polyfills/objectValues.ts (these will be removed so no need)

@joostheijkoop
Copy link

Hey! I was asked to check in here. You are doing some serious transformations. Is there any way I can help out? ;)

Copy link

@0558436961 0558436961 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

يتم اختراق حساب

@saihaj saihaj force-pushed the migrate-to-ts branch 2 times, most recently from 0252608 to e45a056 Compare November 5, 2020 18:13
@saihaj saihaj force-pushed the migrate-to-ts branch 2 times, most recently from caa8334 to 464cbf3 Compare November 10, 2020 02:01
src/language/visitor.ts Outdated Show resolved Hide resolved
@IvanGoncharov
Copy link
Member

@saihaj Can you please squash these two comments:
f47c55f
c5ace4f
Just use git rebase -i and move later commit earlier and squash them.
Please ping me if you need help with it.

@saihaj saihaj force-pushed the migrate-to-ts branch 2 times, most recently from 50a97b9 to bb270c2 Compare December 8, 2020 17:15
@saihaj
Copy link
Member Author

saihaj commented Dec 8, 2020

@IvanGoncharov rebased this with 16.x.x. and squashed those commits

@@ -1 +1 @@
export type PromiseOrValue<+T> = Promise<T> | T;
export type PromiseOrValue<T> = Promise<T> | T;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: I need to check this commit.

tsconfig.json Outdated Show resolved Hide resolved
Co-Authored-By: Kamil Kisiela <kamil.kisiela@gmail.com>
@IvanGoncharov
Copy link
Member

@saihaj That was a long journey thanks a lot for your help 👍

@pspeter3
Copy link

Congrats! When will this be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants