fix: Type annotation cannot appear on a constructor declaration

graphql · Oct 27, 2020 · 4116d5e · 4116d5e
1 parent 2c1b753
commit 4116d5e
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/src/error/GraphQLError.ts b/src/error/GraphQLError.ts
@@ -83,7 +83,7 @@ export class GraphQLError extends Error {
     path?: Maybe<ReadonlyArray<string | number>>,
     originalError?: Maybe<(Error & { readonly extensions?: unknown })>,
     extensions?: Maybe<{ [key: string]: unknown }>,
-  ): void {
+  ) {
     super(message);
 
     // Compute list of blame nodes.

diff --git a/src/language/source.ts b/src/language/source.ts
@@ -23,7 +23,7 @@ export class Source {
     body: string,
     name: string = 'GraphQL request',
     locationOffset: Location = { line: 1, column: 1 },
-  ): void {
+  ) {
     devAssert(
       typeof body === 'string',
       `Body must be a string. Received: ${inspect(body)}.`,

diff --git a/src/type/definition.ts b/src/type/definition.ts
@@ -552,7 +552,7 @@ export class GraphQLScalarType {
   astNode: Maybe<ScalarTypeDefinitionNode>;
   extensionASTNodes: Maybe<ReadonlyArray<ScalarTypeExtensionNode>>;
 
-  constructor(config: $ReadOnly<GraphQLScalarTypeConfig<unknown, unknown>>): void {
+  constructor(config: $ReadOnly<GraphQLScalarTypeConfig<unknown, unknown>>) {
     const parseValue = config.parseValue ?? identityFunc;
     this.name = config.name;
     this.description = config.description;
@@ -699,7 +699,7 @@ export class GraphQLObjectType {
   _fields: Thunk<GraphQLFieldMap<any, any>>;
   _interfaces: Thunk<Array<GraphQLInterfaceType>>;
 
-  constructor(config: $ReadOnly<GraphQLObjectTypeConfig<any, any>>): void {
+  constructor(config: $ReadOnly<GraphQLObjectTypeConfig<any, any>>) {
     this.name = config.name;
     this.description = config.description;
     this.isTypeOf = config.isTypeOf;
@@ -1013,7 +1013,7 @@ export class GraphQLInterfaceType {
   _fields: Thunk<GraphQLFieldMap<any, any>>;
   _interfaces: Thunk<Array<GraphQLInterfaceType>>;
 
-  constructor(config: $ReadOnly<GraphQLInterfaceTypeConfig<any, any>>): void {
+  constructor(config: $ReadOnly<GraphQLInterfaceTypeConfig<any, any>>) {
     this.name = config.name;
     this.description = config.description;
     this.resolveType = config.resolveType;
@@ -1126,7 +1126,7 @@ export class GraphQLUnionType {
 
   _types: Thunk<Array<GraphQLObjectType>>;
 
-  constructor(config: $ReadOnly<GraphQLUnionTypeConfig<any, any>>): void {
+  constructor(config: $ReadOnly<GraphQLUnionTypeConfig<any, any>>) {
     this.name = config.name;
     this.description = config.description;
     this.resolveType = config.resolveType;
@@ -1238,7 +1238,7 @@ export class GraphQLEnumType /* <T> */ {
   _valueLookup: Map<any /* T */, GraphQLEnumValue>;
   _nameLookup: ObjMap<GraphQLEnumValue>;
 
-  constructor(config: $ReadOnly<GraphQLEnumTypeConfig /* <T> */>): void {
+  constructor(config: $ReadOnly<GraphQLEnumTypeConfig /* <T> */>) {
     this.name = config.name;
     this.description = config.description;
     this.extensions = config.extensions && toObjMap(config.extensions);
@@ -1446,7 +1446,7 @@ export class GraphQLInputObjectType {
 
   _fields: Thunk<GraphQLInputFieldMap>;
 
-  constructor(config: $ReadOnly<GraphQLInputObjectTypeConfig>): void {
+  constructor(config: $ReadOnly<GraphQLInputObjectTypeConfig>) {
     this.name = config.name;
     this.description = config.description;
     this.extensions = config.extensions && toObjMap(config.extensions);

diff --git a/src/type/directives.ts b/src/type/directives.ts
@@ -52,7 +52,7 @@ export class GraphQLDirective {
   extensions: Maybe<ReadOnlyObjMap<unknown>>;
   astNode: Maybe<DirectiveDefinitionNode>;
 
-  constructor(config: $ReadOnly<GraphQLDirectiveConfig>): void {
+  constructor(config: $ReadOnly<GraphQLDirectiveConfig>) {
     this.name = config.name;
     this.description = config.description;
     this.locations = config.locations;

diff --git a/src/type/schema.ts b/src/type/schema.ts
@@ -139,7 +139,7 @@ export class GraphQLSchema {
   // Used as a cache for validateSchema().
   __validationErrors: Maybe<ReadonlyArray<GraphQLError>>;
 
-  constructor(config: $ReadOnly<GraphQLSchemaConfig>): void {
+  constructor(config: $ReadOnly<GraphQLSchemaConfig>) {
     // If this schema was built from a source known to be valid, then it may be
     // marked with assumeValid to avoid an additional type system validation.
     this.__validationErrors = config.assumeValid === true ? [] : undefined;

diff --git a/src/utilities/TypeInfo.ts b/src/utilities/TypeInfo.ts
@@ -63,7 +63,7 @@ export class TypeInfo {
     // Initial type may be provided in rare cases to facilitate traversals
     // beginning somewhere other than documents.
     initialType?: GraphQLType,
-  ): void {
+  ) {
     this._schema = schema;
     this._typeStack = [];
     this._parentTypeStack = [];

diff --git a/src/validation/ValidationContext.ts b/src/validation/ValidationContext.ts
@@ -51,7 +51,7 @@ export class ASTValidationContext {
     ReadonlyArray<FragmentDefinitionNode>
   >;
 
-  constructor(ast: DocumentNode, onError: (err: GraphQLError) => void): void {
+  constructor(ast: DocumentNode, onError: (err: GraphQLError) => void) {
     this._ast = ast;
     this._fragments = undefined;
     this._fragmentSpreads = new Map();
@@ -142,7 +142,7 @@ export class SDLValidationContext extends ASTValidationContext {
     ast: DocumentNode,
     schema: Maybe<GraphQLSchema>,
     onError: (err: GraphQLError) => void,
-  ): void {
+  ) {
     super(ast, onError);
     this._schema = schema;
   }
@@ -168,7 +168,7 @@ export class ValidationContext extends ASTValidationContext {
     ast: DocumentNode,
     typeInfo: TypeInfo,
     onError: (err: GraphQLError) => void,
-  ): void {
+  ) {
     super(ast, onError);
     this._schema = schema;
     this._typeInfo = typeInfo;