History pane #232
History pane #232
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
cc-ing @leebyron for design consultation - this is awesome!!!!!!! |
|
Was about to create an issue to ask if such a submission would be appriciated! Glad to see someone already built it! 👍 |
|
Thank you for your work on this! I'd love to take a design pass at this before landing it :) |
|
@tessalt Sorry for letting this go for so long, I don't want this to stale because this is a super important feature for GraphiQL, do you still have time to work on some quick styling changes for this? |
|
@AGS- I should have some time to take a look at it 👍 |
|
@tessalt Overall everything seems good, basically as far as styling goes I think that mimicking the on hover coloring of the GraphiQL.Menu/GraphiQL.Select would be enough. You can see the colors and other options in the css. You're going to have to rebase for this because a couple of things have changed since you originally made the PR. Thanks for taking the time to work on this! |
|
@AGS- rebased and added hover style for the history pane items. |
|
@tessalt Awesome! Thank you for taking the time to work on this! |
Fix issue that was introduced in 0e85c75 (graphql#232)
graphql queries can be verbose, I find I have a scattered collection of queries saved in notes.app when I'm debugging an API 🙃. So I added a "history" panel like Postman has so I can easily re-run queries.
I'm not a designer and I'm not sure this is the best UX, but I've tried to make it as unintrusive as possible. I've had to re-arrange the toolbar a bit to fit it in logically.
Also wrapped the localStorage access in a class so it can be shared between user settings and storing queries.
@asiandrummer