Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History #231

Closed
wants to merge 2 commits into from
Closed

History #231

wants to merge 2 commits into from

Conversation

tessalt
Copy link
Contributor

@tessalt tessalt commented Dec 5, 2016

No description provided.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@tessalt
Copy link
Contributor Author

tessalt commented Dec 5, 2016

this was made by mistake I thought I was on my own fork :(

@tessalt tessalt closed this Dec 5, 2016
@tessalt tessalt deleted the history branch December 5, 2016 21:07
@asiandrummer
Copy link
Contributor

@tessalt took a quick look and this seems to be an awesome contribution if it were to be one ;) are you planning to submit a real PR for this?

@tessalt
Copy link
Contributor Author

tessalt commented Dec 5, 2016

@asiandrummer I was thinking about it but I've got some real UX issues to think through... basically i have no idea where to put the panel.

@asiandrummer
Copy link
Contributor

asiandrummer commented Dec 6, 2016

@tessalt some ideas I can throw:

  • Expandable left-side window just like the doc explorer
  • A toolbar button that opens a dialog that contains the query history

@tessalt
Copy link
Contributor Author

tessalt commented Dec 6, 2016

@asiandrummer re-opened over here with some cleaned-up code #232 (had a different history from this branch because of long story two computers)

acao pushed a commit to acao/graphiql that referenced this pull request Jun 1, 2019
Pass pos to tooltip render function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants