Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure counters have _total suffix #524

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Make sure counters have _total suffix #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* [CHANGE] Ingester cut blocks based on size instead of trace count. Replace ingester `traces_per_block` setting with `max_block_bytes`. This is a **breaking change**. [#474](https://github.com/grafana/tempo/issues/474)
* [CHANGE] Refactor cache section in tempodb. This is a **breaking change** b/c the cache config section has changed. [#485](https://github.com/grafana/tempo/pull/485)
* [CHANGE] New compactor setting for max block size data instead of traces. [#520](https://github.com/grafana/tempo/pull/520)
* [CHANGE/BUGFIX] Rename `tempodb_compaction_objects_written` and `tempodb_compaction_bytes_written` metrics to `tempodb_compaction_objects_written_total` and `tempodb_compaction_bytes_written_total`. [#524](https://github.com/grafana/tempo/pull/524)
* [FEATURE] Added block compression. This is a **breaking change** b/c some configuration fields moved. [#504](https://github.com/grafana/tempo/pull/504)
* [ENHANCEMENT] Serve config at the "/config" endpoint. [#446](https://github.com/grafana/tempo/pull/446)
* [ENHANCEMENT] Switch blocklist polling and retention to different concurrency mechanism, add configuration options. [#475](https://github.com/grafana/tempo/issues/475)
Expand Down
2 changes: 1 addition & 1 deletion docs/tempo/website/troubleshooting/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ Possible reasons why the compactor may not be running are:
- Compactor sitting idle because no block is hashing to it.
- Incorrect configuration settings.
### Diagnosing the issue
- Check metric `tempodb_compaction_bytes_written`
- Check metric `tempodb_compaction_bytes_written_total`
If this is greater than zero (0), it means the compactor is running and writing to the backend.
- Check metric `tempodb_compaction_errors_total`
If this metric is greater than zero (0), check the logs of the compactor for an error message.
Expand Down
4 changes: 2 additions & 2 deletions operations/tempo-mixin/out/tempo-operational.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4958,7 +4958,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(tempodb_compaction_objects_written{cluster=\"$cluster\",job=\"$namespace/compactor\"}[$__rate_interval])) by (level)",
"expr": "sum(rate(tempodb_compaction_objects_written_total{cluster=\"$cluster\",job=\"$namespace/compactor\"}[$__rate_interval])) by (level)",
"interval": "",
"legendFormat": "",
"refId": "A"
Expand Down Expand Up @@ -5067,7 +5067,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(tempodb_compaction_bytes_written{cluster=\"$cluster\",job=\"$namespace/compactor\"}[$__rate_interval])) by (level)",
"expr": "sum(rate(tempodb_compaction_bytes_written_total{cluster=\"$cluster\",job=\"$namespace/compactor\"}[$__rate_interval])) by (level)",
"interval": "",
"legendFormat": "",
"refId": "A"
Expand Down
4 changes: 2 additions & 2 deletions operations/tempo-mixin/tempo-operational.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4358,7 +4358,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(tempodb_compaction_objects_written{cluster=\"$cluster\",job=\"$namespace/compactor\"}[$__rate_interval])) by (level)",
"expr": "sum(rate(tempodb_compaction_objects_written_total{cluster=\"$cluster\",job=\"$namespace/compactor\"}[$__rate_interval])) by (level)",
"interval": "",
"legendFormat": "",
"refId": "A"
Expand Down Expand Up @@ -4453,7 +4453,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(tempodb_compaction_bytes_written{cluster=\"$cluster\",job=\"$namespace/compactor\"}[$__rate_interval])) by (level)",
"expr": "sum(rate(tempodb_compaction_bytes_written_total{cluster=\"$cluster\",job=\"$namespace/compactor\"}[$__rate_interval])) by (level)",
"interval": "",
"legendFormat": "",
"refId": "A"
Expand Down
4 changes: 2 additions & 2 deletions tempodb/compactor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ var (
}, []string{"level"})
metricCompactionObjectsWritten = promauto.NewCounterVec(prometheus.CounterOpts{
Namespace: "tempodb",
Name: "compaction_objects_written",
Name: "compaction_objects_written_total",
Help: "Total number of objects written to backend during compaction.",
}, []string{"level"})
metricCompactionBytesWritten = promauto.NewCounterVec(prometheus.CounterOpts{
Namespace: "tempodb",
Name: "compaction_bytes_written",
Name: "compaction_bytes_written_total",
Help: "Total number of bytes written to backend during compaction.",
}, []string{"level"})
metricCompactionErrors = promauto.NewCounter(prometheus.CounterOpts{
Expand Down