Make sure counters have _total suffix #524
Merged
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
requested review from
achatterjee-grafana,
annanay25,
joe-elliott and
mdisibio
as code owners
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
_total-suffix-counter
branch
from
900aff4
to
61fb269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by the metric:
tempo_receiver_accepted_spansbut that comes from OTel so not touching that. Found these two are missing _total so added it.