Include statusMessage intrinsic attribute in tag search #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcrowe
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
|
Thanks for the PR! It looks like you have a test to fix up and you'll need to sign the CLA in order for us to merge, but these should be easy enough. Feel free to ignore the tempodb test failure. It is just timing out. We need to split it into multiple tests. |
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
|
Thanks @joe-elliott |
|
One more thing I should have mentioned before! Can you add a bugfix changelog entry? Thanks 🙏 |
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
joe-elliott
approved these changes
Oct 30, 2023
3 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Include statusMessage intrinsic attribute in tag search Signed-off-by: Rob Crowe <nobby.crowe@gmail.com> * Add bugfix to changelog Signed-off-by: Rob Crowe <nobby.crowe@gmail.com> --------- Signed-off-by: Rob Crowe <nobby.crowe@gmail.com> (cherry picked from commit 0deec94)
joe-elliott
pushed a commit
that referenced
this pull request
Nov 27, 2023
* Include statusMessage intrinsic attribute in tag search Signed-off-by: Rob Crowe <nobby.crowe@gmail.com> * Add bugfix to changelog Signed-off-by: Rob Crowe <nobby.crowe@gmail.com> --------- Signed-off-by: Rob Crowe <nobby.crowe@gmail.com> (cherry picked from commit 0deec94) Co-authored-by: Rob Crowe <282571+rcrowe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Includes
statusMessagefrom theapi/v2/search/tagsendpoint.Which issue(s) this PR fixes:
Fixes #3081
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]