Skip to content

Commit

Permalink
Include statusMessage intrinsic attribute in tag search (#3084) (#3169)
Browse files Browse the repository at this point in the history
* Include statusMessage intrinsic attribute in tag search

Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>

* Add bugfix to changelog

Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>

---------

Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
(cherry picked from commit 0deec94)

Co-authored-by: Rob Crowe <282571+rcrowe@users.noreply.github.com>
  • Loading branch information
github-actions[bot] and rcrowe committed Nov 27, 2023
1 parent 67d5fb0 commit a9a6d61
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## main / unreleased

* [BUGFIX] Include statusMessage intrinsic attribute in tag search. [#3084](https://github.com/grafana/tempo/pull/3084) (@rcrowe)

## v2.3.0-rc.0 / 2023-10-20

* [CHANGE] Update Go to 1.21 [#2486](https://github.com/grafana/tempo/pull/2829) (@zalegrala)
Expand Down
2 changes: 1 addition & 1 deletion modules/ingester/instance_search_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ func TestInstanceSearchTagsSpecialCases(t *testing.T) {
require.NoError(t, err)
require.Equal(
t,
[]string{"duration", "kind", "name", "status", "traceDuration", "rootServiceName", "rootName"},
[]string{"duration", "kind", "name", "status", "statusMessage", "traceDuration", "rootServiceName", "rootName"},
resp.TagNames,
)
}
Expand Down
1 change: 1 addition & 0 deletions pkg/search/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ func GetVirtualIntrinsicValues() []string {
traceql.IntrinsicKind.String(),
traceql.IntrinsicName.String(),
traceql.IntrinsicStatus.String(),
traceql.IntrinsicStatusMessage.String(),
traceql.IntrinsicTraceDuration.String(),
traceql.IntrinsicTraceRootService.String(),
traceql.IntrinsicTraceRootSpan.String(),
Expand Down

0 comments on commit a9a6d61

Please sign in to comment.