[TraceQL] Add Support for Kind #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
knylander-grafana,
annanay25,
mdisibio,
mapno,
kvrhdn and
zalegrala
as code owners
stoewer
reviewed
Mar 17, 2023
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
zalegrala
approved these changes
Mar 20, 2023
mdisibio
approved these changes
Mar 20, 2023
5 tasks
mdisibio
pushed a commit
to mdisibio/tempo
that referenced
this pull request
Apr 18, 2023
* kind added to the language Signed-off-by: Joe Elliott <number101010@gmail.com> * added to fetch layer Signed-off-by: Joe Elliott <number101010@gmail.com> * todo Signed-off-by: Joe Elliott <number101010@gmail.com> * todos Signed-off-by: Joe Elliott <number101010@gmail.com> * combined status, kind and int preds Signed-off-by: Joe Elliott <number101010@gmail.com> * todos Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * Added kind to tempodb search tests. Fixed false duration condition Signed-off-by: Joe Elliott <number101010@gmail.com> * improve docs Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for the span
kind. I would really like to merge #2190 before this one so I can add some tests forkind.Queries like this are now possible:
or
Other changes:
.dockerignore. Not sure how we went so long without oneCreateStatusPredicateandCreateIntPredicateinto one function.Which issue(s) this PR fixes:
Fixes #1985
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]