Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced TraceQL Tests #2190

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Mar 9, 2023

What this PR does:
This PR adds test to catch advanced and edge case usages of TraceQL. Also moved the SearchTestSuite function into the only place it is currently used.

Fixes #2178

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-elliott joe-elliott merged commit 9ca4bce into grafana:main Mar 20, 2023
mdisibio pushed a commit to mdisibio/tempo that referenced this pull request Apr 18, 2023
* Add advanced traceql tests

Signed-off-by: Joe Elliott <number101010@gmail.com>

* Moved searchTestSuite next to its only usage

Signed-off-by: Joe Elliott <number101010@gmail.com>

* update mod

Signed-off-by: Joe Elliott <number101010@gmail.com>

---------

Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve TraceQL tests
2 participants