Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

added grafana-meta-queries version 0.0.4 #827

Merged
merged 4 commits into from
Mar 3, 2021
Merged

added grafana-meta-queries version 0.0.4 #827

merged 4 commits into from
Mar 3, 2021

Conversation

Gauravshah
Copy link
Contributor

@Gauravshah Gauravshah commented Jan 8, 2021 •
edited
Loading

released version https://github.com/GoshPosh/grafana-meta-queries/releases/tag/0.0.4 for grafana-meta-queries
It adds support for Grafana 7.x

@Gauravshah Gauravshah mentioned this pull request Jan 16, 2021
Closed
@marcusolsson marcusolsson added type/datasource Categorizes the submission as a data source plugin_update labels Jan 19, 2021
@marcusolsson
Copy link
Contributor

Could you please update the PR to the new format?:

{
  "id": "briangann-gauge-panel",
  "type": "panel",
  "url": "https://github.com/briangann/grafana-gauge-panel",
  "versions": [
    {
      "version": "0.0.8",
      "url": "https://github.com/briangann/grafana-gauge-panel",
      "download": {
        "any": {
          "url": "https://github.com/briangann/grafana-gauge-panel/releases/download/v0.0.8/briangann-gauge-panel-0.0.8.zip",
          "md5": "782c973460f330287b7efca5486aa015"
        }
      }
    }
  ]
}

@Gauravshah
Copy link
Contributor Author

thanks @marcusolsson, updated the format

@marcusolsson
Copy link
Contributor

Since the last update of this plugin, we now require all plugin to be signed in order to be published. You can read more on how to sign your plugin here:

Sign a plugin

Once you've signed your plugin, please read the instructions on how to package your plugin:

Package a plugin

If you have any issues signing or packaging your plugin, let me know!

@Gauravshah
Copy link
Contributor Author

cc @ShilpaSivanesan can you please take care of signing .
@marcusolsson we will do it in a couple of weeks. Thanks

@ShilpaSivanesan
Copy link

@marcusolsson here is the link for an unsigned version of our plugin
https://grafana.com/grafana/plugins/goshposh-metaqueries-datasource

Please approve and configure a signature level

@marcusolsson
Copy link
Contributor

It seems like you linked to the plugin page on Grafana.com rather than a link to the plugin archive.

I'm getting an error from the plugin validator for the archive URL in the pull request.

Screen Shot 2021-01-20 at 11 59 56

Since this plugin has been published in the past, we've already configured a Community signature level for you. You should be able to sign it with the instructions I linked to.

@Gauravshah
Copy link
Contributor Author

@ShilpaSivanesan we might want to look into https://grafana.com/docs/grafana/latest/developers/plugins/package-a-plugin/ to package it better

@Gauravshah Gauravshah mentioned this pull request Jan 27, 2021
Closed
@Gauravshah
Copy link
Contributor Author

thanks @marcusolsson fixed it now.
Screenshot 2021-02-04 at 2 09 41 AM

@Gauravshah Gauravshah mentioned this pull request Feb 4, 2021
Open
@Gauravshah
Copy link
Contributor Author

updated version in plugin.json
Screenshot 2021-02-06 at 10 19 25 PM

@marcusolsson
Copy link
Contributor

I'm having some problems testing this plugin.

CleanShot 2021-02-11 at 15 27 39@2x

I've been trying this on 7.0.0 and 7.3.7, but both versions report the same error. Could you help me figure out what I'm doing wrong?

@marcusolsson marcusolsson added the milestone/needs-feedback Submission needs feedback from the author label Feb 11, 2021
@Gauravshah
Copy link
Contributor Author

Gauravshah commented Feb 11, 2021 via email

@marcusolsson
Copy link
Contributor

marcusolsson commented Feb 11, 2021 •
edited
Loading

Thank you! I'm getting another error now. Any idea what it could be?

CleanShot 2021-02-11 at 15 45 33@2x

Switching to Arithmetic, I'm getting no error, but no data either?

CleanShot 2021-02-11 at 15 49 11@2x

@Gauravshah
Copy link
Contributor Author

Gauravshah commented Feb 11, 2021 via email

@Gauravshah
Copy link
Contributor Author

Gauravshah commented Feb 11, 2021 via email

@WafflesMcDuff
Copy link

Among known limitations it doesn’t work with influx DB. It also doesn’t support grouped query.
…
On Thu, 11 Feb 2021 at 8:45 PM, Gaurav Shah @.> wrote: It doesn’t work with grafana 7.4 just in case you are using that. Can you also plot a table without arithmetic to see the column names. Just in case there is a change of name. On Thu, 11 Feb 2021 at 8:20 PM, Marcus Olsson @.> wrote: > Thank you! I'm getting another error now. Any idea what it could be? > > [image: CleanShot 2021-02-11 at 15 45 @.*** > https://user-images.githubusercontent.com/8396880/107651811-3a05bb80-6c80-11eb-9ce5-8cbd81f31bb3.png > > Switching to Arithmetic, I'm getting no error, but no data either? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#827 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AAEXQD3VL6D6IWDEEYF2ZN3S6PVENANCNFSM4V2JPGMA > . >

This used to work with InfluxDB. When did it stop supporting InfluxDB?
The whole reason I've been waiting for this release is to use with InfluxDB datasources.

@Gauravshah
Copy link
Contributor Author

Gauravshah commented Feb 11, 2021 via email

@Gauravshah
Copy link
Contributor Author

@MarcusCalidus do we need to update anything else to get this signed ?

@marcusolsson marcusolsson merged commit 140586d into grafana:master Mar 3, 2021
@marcusolsson
Copy link
Contributor

Published! 🎉

@marcusolsson
Copy link
Contributor

Hm. I see now that the grafanaDependency is set to 4.x.x which means only users using Grafana 4 will be able to install the plugin using grafana-cli (they can still install it manually). If you wish to let users on more recent versions of Grafana install your plugin, you need to update the grafanaDependency to something like >=4.0.0.

Let me know if you want to make the update and I'll expedite the review for you.

@Gauravshah Gauravshah mentioned this pull request Mar 3, 2021
Merged
@Gauravshah
Copy link
Contributor Author

thanks for pointing out the issue @marcusolsson created a PR here #890

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
milestone/needs-feedback Submission needs feedback from the author type/datasource Categorizes the submission as a data source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravshah @marcusolsson @ShilpaSivanesan @WafflesMcDuff