-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the plugin for grafana 7.1.x #112
Conversation
The one thing I'm not certain about his how backwards compatible this is. I am pretty sure the Observable change went in quite awhile ago, but this may need some love to support older versions of Grafana. |
Thanks @craigching for your contribution. |
fixes #104 |
it was atleast added to mixed source in 6.4 grafana/grafana#19037 |
@ShilpaSivanesan can you review and check basic compatibility ? |
Yes, exactly. Thanks for taking the time to incorporate my PR! Let me know if you want any changes. |
Any updates on getting this merged? I'd love to help in any way I can. |
team is stuck with internal projects, Will request @ShilpaSivanesan to have a look at it next week. Apologies for the delay |
Is there any update regarding this fix. Really keen for this as the plugin is currently unusable for us at the moment. Appreciate all of the work in producing and maintaining this plugin, and understand the pressure of competing priorities. Just keen for an update. |
Any updates on this? We are also in need of this plugin to be fixed for later versions of grafana so we can continue monitoring our systems... Thanks so much. |
seems to be compatibility issue with 7.3 vs 7.2 and previous versions. Looking into fixing further |
Thanks, @craigching for your contribution. |
Hi |
waiting on approval from grafana grafana/grafana-plugin-repository#827 |
This fixes the plugin for Grafana 7.1.x. The return from ds.query() is an Observable, which can be converted to a promise with
toPromise()