Flake: List Add/Delete Unit Tests #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both unit tests had the same issue - under high load, the workqueue could process the current data set that was batched for updates, resulting in non-deterministic test state. Moving the `sc.Run(...)` operation until only the moment where update checks are required resolves this issue. Fixes googleforgames#3625 Fixes googleforgames#3622
markmandel
added
the
area/tests
github-actions
bot
added
kind/cleanup
|
Build Succeeded 👏 Build Id: 048a63f9-c99a-4bba-9f4b-9b4994ca9076 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
approved these changes
Feb 1, 2024
zmerlynn
reviewed
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Both unit tests had the same issue - under high load, the workqueue could process the current data set that was batched for updates, resulting in non-deterministic test state.
Moving the
sc.Run(...)operation until only the moment where update checks are required resolves this issue.Which issue(s) this PR fixes:
Fixes #3625
Fixes #3622
Special notes for your reviewer: