Flaky: unit test TestSDKServerAddListValue

[ashutosji]

What happened:

Step #20 - "tests": --- FAIL: TestSDKServerAddListValue (31.98s)
Step #20 - "tests":     --- FAIL: TestSDKServerAddListValue/Add_multiple_values_past_capacity (1.12s)
Step #20 - "tests":         sdkserver_test.go:1477: 
Step #20 - "tests":             	Error Trace:	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1477
Step #20 - "tests":             	Error:      	Not equal: 
Step #20 - "tests":             	            	expected: v1.ListStatus{Capacity:10, Values:[]string{"one", "two", "three", "four", "five", "six", "seven", "eight", "nine", "ten"}}
Step #20 - "tests":             	            	actual  : v1.ListStatus{Capacity:10, Values:[]string{"one", "two", "three", "four", "five", "six", "seven", "eight", "nine"}}
Step #20 - "tests":             	            	
Step #20 - "tests":             	            	Diff:
Step #20 - "tests":             	            	--- Expected
Step #20 - "tests":             	            	+++ Actual
Step #20 - "tests":             	            	@@ -2,3 +2,3 @@
Step #20 - "tests":             	            	  Capacity: (int64) 10,
Step #20 - "tests":             	            	- Values: ([]string) (len=10) {
Step #20 - "tests":             	            	+ Values: ([]string) (len=9) {
Step #20 - "tests":             	            	   (string) (len=3) "one",
Step #20 - "tests":             	            	@@ -11,4 +11,3 @@
Step #20 - "tests":             	            	   (string) (len=5) "eight",
Step #20 - "tests":             	            	-  (string) (len=4) "nine",
Step #20 - "tests":             	            	-  (string) (len=3) "ten"
Step #20 - "tests":             	            	+  (string) (len=4) "nine"
Step #20 - "tests":             	            	  }
Step #20 - "tests":             	Test:       	TestSDKServerAddListValue/Add_multiple_values_past_capacity

What you expected to happen:
Tests should pass.

How to reproduce it (as minimally and precisely as possible):
Not entirely sure. Seems to mostly happen in CI, have yet to try and reproduce locally.

Anything else we need to know?:

Environment:

• Agones version: dev
• Kubernetes version (use kubectl version): varies
• Cloud provider or hardware configuration: GKE
• Install method (yaml/helm): helm
• Troubleshooting guide log(s): see above what happened section
• Others: N/A

[markmandel]

Context:

agones/pkg/sdkserver/sdkserver_test.go

Line 1339 in e88f7c5

func TestSDKServerAddListValue(t *testing.T) {

[markmandel]

Three PR's it was reported in:

• resolve flaky e2e test #3616
• fix(SdkList): fix list delete values panic #3615
• Update Site Go Version #3595

Weirdly, I've run this on main 200 tiemes and have yet to have it fail. So very odd.