Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes race condition bug with Pod not being scheduled before Ready() #357

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Fixes race condition bug with Pod not being scheduled before Ready() #357

merged 2 commits into from
Sep 20, 2018

Commits on Sep 19, 2018

  1. Fixes race condition bug with Pod not being scheduled before Ready() 

    This fix does several things:

1. Breaks out ip and port setting of the `Status` into its own state, to make
    implementation and testing easier.
1. Listen for Pod updates, and if a Pod is a `GameServer` pod that has had
    its `NodeName` set, then queue the backing `GameServer`
1. Finally - if Ready() gets called before any of this, populate the `Status` ip
   and port values at this time as well.

Fixes googleforgames#354
    @markmandel
    markmandel committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    7ba2552 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Merge branch 'master' into bug/no-node-pod

    @markmandel
    markmandel authored Sep 20, 2018
    Configuration menu
    Copy the full SHA
    c9828d1 View commit details
    Browse the repository at this point in the history