Fixes race condition bug with Pod not being scheduled before Ready() #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed 😱 Build Id: 112175e2-565d-4f70-8bf4-5a3ea7c9d9c1 Build Logs |
pkg/gameservers/controller_test.go
Outdated
| @@ -109,7 +120,7 @@ func TestControllerSyncGameServer(t *testing.T) { | |||
|
|
|||
| err = c.syncGameServer("default/test") | |||
| assert.Nil(t, err) | |||
| assert.Equal(t, 2, updateCount, "update reactor should twice") | |||
| assert.Equal(t, 3, updateCount, "update reactor should twice") | |||
This fix does several things:
1. Breaks out ip and port setting of the `Status` into its own state, to make
implementation and testing easier.
1. Listen for Pod updates, and if a Pod is a `GameServer` pod that has had
its `NodeName` set, then queue the backing `GameServer`
1. Finally - if Ready() gets called before any of this, populate the `Status` ip
and port values at this time as well.
Fixes googleforgames#354
markmandel
force-pushed
the
bug/no-node-pod
branch
from
acad386
to
7ba2552
Compare
|
Build Failed 😱 Build Id: 53501db2-ff21-45fe-bac8-320d81f081e7 Build Logs |
|
Build Failed 😱 Build Id: 25a57b4d-5288-4c6d-b678-f2140f3bc6f7 Build Logs |
|
Build Failed 😱 Build Id: 018199ba-a1af-4bc2-8ef1-08ad81093b1a Build Logs |
|
Build Succeeded 👏 Build Id: df8054fd-4d03-4010-94a3-2d932110c9b2 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix does several things:
Statusinto its own state, to makeimplementation and testing easier.
GameServerpod that has hadits
NodeNameset, then queue the backingGameServerStatusipand port values at this time as well.
Fixes #354