Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in examples/simple-game-server/README.md #3398

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Fixed typo, and also cleaned up the table Markdown formatting.

Which issue(s) this PR fixes:

Originally referenced in #3319

Special notes for your reviewer:

N/A

Fixed typo, and also cleaned up the table Markdown formatting.
@markmandel markmandel added the kind/documentation Documentation for Agones label Sep 21, 2023
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Sep 21, 2023
@markmandel markmandel changed the title Fix type in examples/simple-game-server/README.md Fix typo in examples/simple-game-server/README.md Sep 21, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4a61cb88-7a89-4dda-a698-93f6b2ebcce3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3398/head:pr_3398 && git checkout pr_3398
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-b6b31d4-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Sep 22, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9978d8d5-b8ac-43d4-9fbd-912339da7343

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3398/head:pr_3398 && git checkout pr_3398
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-6d50cd7-amd64

@gongmax gongmax merged commit 65a5aed into googleforgames:main Sep 22, 2023
3 checks passed
@markmandel markmandel deleted the docs/cleanup-simple-readme branch September 27, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants