-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample-game-server document bug fix #3319
Conversation
change UNHEATHY to UNHEALTHY
Update README.md
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Good catch! That's been there for YEARS. |
Build Failed 😱 Build Id: 3e9c6733-36b1-4077-bc18-922d5bd7cf25 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Looks like a flake in the nodejs conformance tests
Weird that it didn't seem to succeed on retry (did it retry?) |
Just noting - once you sign the CLA, I'll kickoff the job again, and I expect it will pass. That's an odd flake. |
Just touching base on this update, seeing if you had time to submit the CLA? |
Just gently bumping this - if you can get the CLA sorted, we'd be happy to take this submission! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, hellof20 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -17,7 +17,7 @@ There are some text commands you can send the server to affect its behavior: | |||
| Command | Behavior | | |||
| ------------------- | ---------------------------------------------------------------------------------------- | | |||
| "EXIT" | Causes the game server to exit cleanly calling `os.Exit(0)` | | |||
| "UNHEATHY" | Stopping sending health checks | | |||
| "UNHEALTHY" | Stopping sending health checks | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the indent before "|"
Closing since this has been a while. Submitting a separate PR to reformat the tables as well. |
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Change UNHEATHY to UNHEALTHY
Special notes for your reviewer: