Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample-game-server document bug fix #3319

Closed
wants to merge 2 commits into from
Closed

sample-game-server document bug fix #3319

wants to merge 2 commits into from

Conversation

hellof20
Copy link

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
Change UNHEATHY to UNHEALTHY

Special notes for your reviewer:

@google-cla
Copy link

google-cla bot commented Aug 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the kind/documentation Documentation for Agones label Aug 10, 2023
@markmandel
Copy link
Member

Good catch! That's been there for YEARS.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3e9c6733-36b1-4077-bc18-922d5bd7cf25

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Looks like a flake in the nodejs conformance tests

Watch ERROR Error: 14 UNAVAILABLE: Connection dropped
    at Object.callErrorFromStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call.js:31:19)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:360:49)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:328:181)
    at /go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:188:78
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
for call at
    at ServiceClientImpl.makeServerStreamRequest (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:343:34)
    at ServiceClientImpl.watchGameServer (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/make-client.js:105:19)
    at AgonesSDK.watchGameServer (/go/src/agones.dev/agones/sdks/nodejs/src/agonesSDK.js:132:30)
    at connect (/go/src/agones.dev/agones/test/sdk/nodejs/testSDKClient.js:25:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 14,
  details: 'Connection dropped',
  metadata: Metadata { internalRepr: Map(0) {}, options: {} }
}
make[2]: *** [includes/sdk.mk:145: run-sdk-conformance-no-build] Error 1

Weird that it didn't seem to succeed on retry (did it retry?)

@markmandel
Copy link
Member

Just noting - once you sign the CLA, I'll kickoff the job again, and I expect it will pass. That's an odd flake.

@markmandel
Copy link
Member

Just touching base on this update, seeing if you had time to submit the CLA?

@markmandel
Copy link
Member

Just gently bumping this - if you can get the CLA sorted, we'd be happy to take this submission!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, hellof20
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -17,7 +17,7 @@ There are some text commands you can send the server to affect its behavior:
| Command | Behavior |
| ------------------- | ---------------------------------------------------------------------------------------- |
| "EXIT" | Causes the game server to exit cleanly calling `os.Exit(0)` |
| "UNHEATHY" | Stopping sending health checks |
| "UNHEALTHY" | Stopping sending health checks |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indent before "|"

@markmandel
Copy link
Member

Closing since this has been a while. Submitting a separate PR to reformat the tables as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants